-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kusto_database
support data source kusto_database_data_source.go
#16180
kusto_database
support data source kusto_database_data_source.go
#16180
Conversation
1762caf
to
a1e6c62
Compare
3727003
to
c0d41cb
Compare
ef258a4
to
d91762e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @heiazuo. I've left a couple of minor comments inline bu overall this is looking good so far. Thanks!
Thanks@catriona-m ,thanks for your suggestion, I made the changes as suggested |
Thanks for updating this @heiazuo. Looks like there is a test failure, once this is fixed we can look at merging this. Thanks!
|
1 similar comment
Thanks for updating this @heiazuo. Looks like there is a test failure, once this is fixed we can look at merging this. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating @heiazuo. I ran the test again and it looks like there is still a failure here:
------- Stdout: -------
=== RUN TestAccKustoDatabaseDataSource_basic
=== PAUSE TestAccKustoDatabaseDataSource_basic
=== CONT TestAccKustoDatabaseDataSource_basic
testcase.go:110: Step 1/1 error: Check failed: Check 2/4 error: data.azurerm_kusto_database.test: Attribute 'soft_delete_period' expected to be set
--- FAIL: TestAccKustoDatabaseDataSource_basic (2646.59s)
FAIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heiazuo LGTM! 🦩
This functionality has been released in v3.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
create a public pull request for
kusto_database
support data sourcekusto_database_data_source.go
Link to #15133