new resources: azurerm_data_lake_analytics_account & azurerm_data_lake_analytics_firewall_rule #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_analytics_firewall_rule
paultyng
reviewed
Jul 20, 2018
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/Azure/azure-sdk-for-go/services/datalake/analytics/mgmt/2016-11-01/account" |
There was a problem hiding this comment.
these imports probably need some minor reordering.
| client := meta.(*ArmClient).dataLakeAnalyticsAccountClient | ||
| ctx := meta.(*ArmClient).StopContext | ||
|
|
||
| log.Printf("[INFO] preparing arguments for Azure ARM Date Lake Store creation.") |
There was a problem hiding this comment.
maybe add the name to this log?
| client := meta.(*ArmClient).dataLakeAnalyticsFirewallRulesClient | ||
| ctx := meta.(*ArmClient).StopContext | ||
|
|
||
| log.Printf("[INFO] preparing arguments for Date Lake Analytics Firewall Rule creation.") |
There was a problem hiding this comment.
can you add name to this log?
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
| "log" |
|
Not sure why Travis failed, hmmm... |
paultyng
approved these changes
Jul 20, 2018
|
|
||
| tier = "Commitment100AUHours" | ||
|
|
||
| default_store_account_name = "${azurerm_data_lake_store |
There was a problem hiding this comment.
this test is invalid?
| resource_group_name = "${azurerm_resource_group.test.name}" | ||
| location = "${azurerm_resource_group.test.location}" | ||
|
|
||
| default_store_account_name = "${azurerm_data_lake_store |
| resource_group_name = "${azurerm_resource_group.test.name}" | ||
| location = "${azurerm_resource_group.test.location}" | ||
|
|
||
| default_store_account_name = "${azurerm_data_lake_store |
katbyte
force-pushed
the
r-datalake-analytics-account_firewall
branch
from
2d61d0d to
d05a178
Compare
katbyte
added a commit
that referenced
this pull request
Jul 20, 2018
|
tests pass: |
This was referenced Jul 30, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.