Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public_network_access_enabled does not really work for resource azurerm_machine_learning_workspace #16177

Closed
mingweihe opened this issue Mar 31, 2022 · 2 comments · Fixed by #18279
Labels
enhancement service/machine-learning upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR

Comments

@mingweihe
Copy link

public_network_access_enabled = false
public_network_access_enabled = true
both the above setup are not working for the azure machine learning workspace
I tried azurerm 2.76.0, 2.78.0, 3.0.2, all same
image
The expected behavior should be:
false -> Disabled
true -> All networks

Please take a look, thanks!

@stephybun
Copy link
Member

stephybun commented Apr 7, 2022

Hi @mingweihe,

Thanks for raising this issue.

There seem to be two problems here:

  1. The property public_network_access_enabled doesn't actually control whether public network access is disabled or enabled, it actually sets whether public access is allowed when behind a virtual network. So this property should be renamed to something that reflects this behaviour better.

  2. I attempted to add a new property that does control the public network access behaviour of the workspace but unfortunately it appears to be broken in the API. Changing the value doesn't seem to have any effect and it isn't returned by the API.

I will open a PR to address 1. and i've also raised this issue Azure/azure-rest-api-specs#18601 to address 2.

Thanks again for bringing this to our attention and let's hope Azure can fix this in the API soon!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/machine-learning upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
2 participants