new resource azurerm_spring_cloud_gateway

[ms-henglu]

[katbyte]

Thanks @ms-henglu - I've left some comments inline, additionally we may need to adjust the timeout duration as:

<div class="rightBlock expandedDetails" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; float: right; background-color: rgba(245, 245, 245, 0.81); border-left-width: 5px; border-left-style: solid; border-left-color: rgb(255, 255, 255); border-bottom-width: 5px; border-bottom-style: solid; border-bottom-color: rgb(255, 255, 255); caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Roboto, Oxygen, Ubuntu, Cantarell, &quot;Droid Sans&quot;, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 13px;"><br class="Apple-interchange-newline"><div class="icon_before icon16 collapser collapser_expanded" title="Click to hide the details block" style="float: right; height: 2em; padding: 5px; cursor: pointer;"></div><div class="relatedBuildsWrapper" style="border-right-width: 3px; border-right-style: solid; border-right-color: white; float: right;">

  | Current failure: |   | #462 | Changes (7) | 29 Apr 22 03:32
-- | -- | -- | -- | -- | --
  | First failure: |   | #420 | Changes (2) | 01 Apr 22 10:21

<div id="div_iaa_17c331b803a"></div></div></div><span style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Roboto, Oxygen, Ubuntu, Cantarell, &quot;Droid Sans&quot;, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255); float: none; display: inline !important;"></span><span style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Roboto, Oxygen, Ubuntu, Cantarell, &quot;Droid Sans&quot;, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255); float: none; display: inline !important;"></span><div class="testMetadata" id="testMetadata_tdi_17c331b8038" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Roboto, Oxygen, Ubuntu, Cantarell, &quot;Droid Sans&quot;, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 13px;"></div><pre class="fullStacktrace" id="fullStacktrace_285074_8838383897402829173" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; font-stretch: normal; font-size: 12px; line-height: 1.2em; font-family: Menlo, &quot;Bitstream Vera Sans Mono&quot;, &quot;Ubuntu Mono&quot;, Consolas, &quot;Courier New&quot;, Courier, monospace; padding: 3px 3px 0px; color: darkred; margin-top: 0.5em; margin-bottom: 0.5em; white-space: pre-wrap; overflow-wrap: break-word;">------- Stdout: -------
=== RUN   TestAccSpringCloudGateway_complete
=== PAUSE TestAccSpringCloudGateway_complete
=== CONT  TestAccSpringCloudGateway_complete
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for creation/update of Spring Cloud Gateway: (Gateway Name "default" / Spring Name "acctest-sc-220429033421762034" / Resource Group "acctestRG-spring-220429033421762034"): Future#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded
        
          with azurerm_spring_cloud_gateway.test,
          on terraform_plugin_test.tf line 20, in resource "azurerm_spring_cloud_gateway" "test":
          20: resource "azurerm_spring_cloud_gateway" "test" {
        
--- FAIL: TestAccSpringCloudGateway_complete (2392.87s)
FAIL</pre>Current failure:	refs/pull/16175/merge	[#462 ](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=285074&tab=buildResultsDiv&buildTypeId=TerraformOpenSource_TerraformProviders_AzureRMPublic_AZURERM_SERVICE_PUBLIC_SPRINGCLOUD) 	[Changes (7)](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=285074&tab=buildChangesDiv&buildTypeId=TerraformOpenSource_TerraformProviders_AzureRMPublic_AZURERM_SERVICE_PUBLIC_SPRINGCLOUD) 	29 Apr 22 03:32
	First failure: 	refs/pull/16175/merge	[#420 ](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=275386&tab=buildResultsDiv&buildTypeId=TerraformOpenSource_TerraformProviders_AzureRMPublic_AZURERM_SERVICE_PUBLIC_SPRINGCLOUD) 	[Changes (2)](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=275386&tab=buildChangesDiv&buildTypeId=TerraformOpenSource_TerraformProviders_AzureRMPublic_AZURERM_SERVICE_PUBLIC_SPRINGCLOUD) 	01 Apr 22 10:21
 ------- Stdout: -------
=== RUN   TestAccSpringCloudGateway_complete
=== PAUSE TestAccSpringCloudGateway_complete
=== CONT  TestAccSpringCloudGateway_complete
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for creation/update of Spring Cloud Gateway: (Gateway Name "default" / Spring Name "acctest-sc-220429033421762034" / Resource Group "acctestRG-spring-220429033421762034"): Future#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded
        
          with azurerm_spring_cloud_gateway.test,
          on terraform_plugin_test.tf line 20, in resource "azurerm_spring_cloud_gateway" "test":
          20: resource "azurerm_spring_cloud_gateway" "test" {
        
--- FAIL: TestAccSpringCloudGateway_complete (2392.87s)
FAIL

[ms-henglu]

@katbyte , thanks for code review, I've updated this PR, would you please take another look? Thanks!

[katbyte]

thanks @ms-henglu but i think you still need to adjsut the timeouts:

------- Stdout: -------
=== RUN   TestAccSpringCloudGateway_complete
=== PAUSE TestAccSpringCloudGateway_complete
=== CONT  TestAccSpringCloudGateway_complete
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for creation/update of Spring Cloud Gateway: (Gateway Name "default" / Spring Name "acctest-sc-220505150458427321" / Resource Group "acctestRG-spring-220505150458427321"): Code="CreateOrUpdateSpringCloudGatewayFailed" Message="CreateOrUpdateSpringCloudGatewayFailed"
        
          with azurerm_spring_cloud_gateway.test,
          on terraform_plugin_test.tf line 20, in resource "azurerm_spring_cloud_gateway" "test":
          20: resource "azurerm_spring_cloud_gateway" "test" {
        
--- FAIL: TestAccSpringCloudGateway_complete (3365.33s)
FAIL

[ms-henglu]

Hi @katbyte , now all tests passed, please take another look.

[katbyte]

Thanks @ms-henglu - LGTM 🌿

[github-actions]

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.