Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_factory_linked_service_sql_server_resource supports user_name #16118

Merged
merged 6 commits into from
Apr 21, 2022
Merged

data_factory_linked_service_sql_server_resource supports user_name #16118

merged 6 commits into from
Apr 21, 2022

Conversation

qiqingzhang
Copy link
Contributor

@qiqingzhang qiqingzhang commented Mar 29, 2022 •
edited
Loading

create a public pull request for data_factory_linked_service_sql_server_resource supports userName

Link to #15475
test result：
image

@qiqingzhang qiqingzhang force-pushed the branch-add_userName_to_factory_linked branch from dd75256 to 7013f4a Compare March 29, 2022 07:02
catriona-m
catriona-m requested changes Mar 29, 2022
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heiazuo just left one small comment. Also, looks like there could be some linting to resolve here?

internal/services/datafactory/data_factory_linked_service_sql_server_resource.go
@@ -266,6 +275,7 @@ func resourceDataFactoryLinkedServiceSQLServerRead(d *pluginsdk.ResourceData, me
}

if properties := sqlServer.SQLServerLinkedServiceTypeProperties; properties != nil {
d.Set("user_name", properties.UserName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be nil checked before setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for this comment @catriona-m，nil will be checked before setting in the Set function

@qiqingzhang qiqingzhang force-pushed the branch-add_userName_to_factory_linked branch from 7013f4a to c42a38e Compare April 6, 2022 05:26
katbyte
katbyte approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@katbyte katbyte merged commit bdf4fae into hashicorp:main Apr 21, 2022
@katbyte katbyte changed the title data_factory_linked_service_sql_server_resource supports userName data_factory_linked_service_sql_server_resource supports user_name Apr 21, 2022
@github-actions github-actions bot added this to the v3.3.0 milestone Apr 21, 2022
katbyte added a commit that referenced this pull request Apr 21, 2022
@katbyte
CHANGELOG.md for #16118
6d7eafd
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/data-factory size/S
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qiqingzhang @katbyte @catriona-m