azurerm_virtual_machine_scale_set: adding a plan block for Marketplace images
#161
Conversation
| @@ -653,6 +688,10 @@ func resourceArmVirtualMachineScaleSetRead(d *schema.ResourceData, meta interfac | |||
| d.Set("extension", extension) | |||
| } | |||
|
|
|||
| if resp.Plan != nil { | |||
| d.Set("plan", flattenAzureRmVirtualMachineScaleSetPlan(resp.Plan)) | |||
There was a problem hiding this comment.
for complex Set operations like this, it would be good to throw an error if the set fails
| }, | ||
| }, | ||
| }, | ||
| Set: resourceArmVirtualMachineScaleSetPlanHash, |
There was a problem hiding this comment.
I think we can just use the Default Set Hash - it does exactly the same thing you have done but without a custom func for it
| func flattenAzureRmVirtualMachineScaleSetPlan(plan *compute.Plan) []interface{} { | ||
| result := make(map[string]interface{}) | ||
|
|
||
| result["name"] = *plan.Name |
There was a problem hiding this comment.
No chance these can be missing right? If they can, then panic city...
There was a problem hiding this comment.
According to the docs, no - as all 3 fields are required if this block is specified
|
Updated and tests still pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Adding a
planblock to VMSS to match the VM resource so that we support deploying Marketplace imagesTests pass:
Fixes #95