Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource azurerm_spring_cloud_configuration_service #16087

Merged
merged 5 commits into from
May 3, 2022
Merged

new resource azurerm_spring_cloud_configuration_service #16087

merged 5 commits into from
May 3, 2022

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Mar 28, 2022 •
edited
Loading

image

@ms-henglu
Copy link
Contributor Author

Thanks @katbyte , I've updated it, please take another look.

@ms-henglu ms-henglu requested a review from katbyte April 7, 2022 02:15
katbyte
katbyte requested changes Apr 21, 2022
View reviewed changes
internal/services/springcloud/spring_cloud_configuration_service_resource.go Outdated Show resolved Hide resolved
internal/services/springcloud/spring_cloud_configuration_service_resource.go
Optional: true,
},

"username": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be

Suggested change
"username": {
"user": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe not necessary. Because this aligns with https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/spring_cloud_service#username

website/docs/r/spring_cloud_configuration_service.html.markdown Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit a7b1496 into hashicorp:main May 3, 2022
@github-actions github-actions bot added this to the v3.5.0 milestone May 3, 2022
katbyte added a commit that referenced this pull request May 3, 2022
@katbyte
CHANGELOG for #16087
a9b2b99
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/spring size/XL
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-henglu @katbyte