Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies Update digitaltwins api version to 2020-12-01 #16044

Merged
merged 4 commits into from
Mar 30, 2022
Merged

dependencies Update digitaltwins api version to 2020-12-01 #16044

merged 4 commits into from
Mar 30, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Mar 25, 2022 •
edited
Loading

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Mar 28, 2022

Test result
image

catriona-m
catriona-m requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o. Left one minor comment inline, otherwise this is looking good!

internal/services/digitaltwins/digital_twins_instance_resource.go Outdated Show resolved Hide resolved
@myc2h6o @catriona-m
Update error message
71dec6f 
Co-authored-by: catriona-m <[email protected]>
@myc2h6o
Copy link
Contributor Author

myc2h6o commented Mar 30, 2022

Hi @catriona-m thanks for reviewing the change! I've resolved the comment, please take a look

catriona-m
catriona-m approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o LGTM!

@catriona-m catriona-m merged commit eedcc0b into hashicorp:main Mar 30, 2022
@github-actions github-actions bot added this to the v3.1.0 milestone Mar 30, 2022
catriona-m added a commit that referenced this pull request Mar 30, 2022
@catriona-m
Update changelog for #16044
3ae23ab
@myc2h6o myc2h6o deleted the digital_twin_api branch March 30, 2022 11:56
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
dependencies service/digital-twins size/XL
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@myc2h6o @catriona-m