Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to allow MySQL and PostgreSQL to upgrade SKU without destroying existing resource #1598

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Fix to allow MySQL and PostgreSQL to upgrade SKU without destroying existing resource #1598

merged 2 commits into from
Jul 18, 2018

Conversation

WodansSon
Copy link
Collaborator

(Fixes #1597)

@WodansSon WodansSon added this to the 1.10.0 milestone Jul 18, 2018
JunyiYi
JunyiYi approved these changes Jul 18, 2018
View reviewed changes
Copy link

@JunyiYi JunyiYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

katbyte
katbyte approved these changes Jul 18, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreyCline,

Aside from one very minor comment LGTM 👍

azurerm/resource_arm_mysql_server_test.go
family = "Gen5"
}

storage_profile {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if these were aligned

azurerm/resource_arm_postgresql_server_test.go Outdated
}

storage_profile {
storage_mb = 4194304
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, these should be aligned.

@WodansSon
Copy link
Collaborator Author

image

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit 5285f4b into master Jul 18, 2018
@WodansSon WodansSon deleted the e-sku branch July 18, 2018 21:25
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JunyiYi JunyiYi JunyiYi approved these changes

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
enhancement service/mysql service/postgresql
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Allow MySQL and PostgreSQL to upgrade SKU without destroying existing instance.
3 participants
@WodansSon @katbyte @JunyiYi