Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: working through the todo's for 3.0 #15973

Merged
merged 32 commits into from
Mar 23, 2022
Merged

refactor: working through the todo's for 3.0 #15973

merged 32 commits into from
Mar 23, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR's a little bit of everything whilst passing through the TODO's for 3.0

@tombuildsstuff
portal: requires import
e95e081
@tombuildsstuff
redis: refactoring the validate max memory policy validation function
852e26a
@tombuildsstuff
refactor: cleanup of unnecessary todo's
b92ea05
@tombuildsstuff
postgres: clarifying a todo
1e57ab2
@tombuildsstuff
r/redis_cache: updating the todo
7e37e70
@tombuildsstuff
policy: removing the old id parser
21e0c00
@tombuildsstuff
policy: removing an unnecessary todo
42acca2
@tombuildsstuff
r/mysql_server: removing support for 5.6 (not present in the docs)
4e162b1
@tombuildsstuff
r/mssql_server: migrating to use the new identity type
48cd9eb
@tombuildsstuff
machinelearning: switching to use the new identity types
1ca8768
@tombuildsstuff
r/log_analytics_cluster_customer_managed_key: swithcing to use the Cl…
5584b2b 
…uster ID directly
@tombuildsstuff
todo cleanup
0e258db
@tombuildsstuff
iothub: documenting the change
826d543
@tombuildsstuff
hpccache: fixing the validation message
4b0ce70
@tombuildsstuff
r/firewall_policy: updating the docs to account for the identity changes
a5c4e72
@tombuildsstuff
r/eventgrid_topic: tests can now run anywhere
7105b46
@tombuildsstuff
refactor: working through todo's
e83fc1e
@tombuildsstuff
appconfig: handling the app configuration being deleted
8d33cf0 
This allows items within the App Configuration to be detected as requiring recreation
which fixes #14665
@tombuildsstuff
apim: updating the todo to be for 4.0
0fbe520
@tombuildsstuff
terrafmt
d7e926f
@tombuildsstuff
docs: note about azurerm_dashboard being renamed
2d8f525
@tombuildsstuff
r/portal_dashboard: updating the docs
e14c3aa
@tombuildsstuff
r/log_analytics_cluster_customer_managed_key: updating the Exists fun…
a003525 
…ction to check that CMK exists
@tombuildsstuff
r/function_app_slot: removing/documenting the identity changes
33377de
@tombuildsstuff
r/function_app: documenting the identity block changes
75aecbc
@tombuildsstuff
r/app_service_slot: documenting the identity changes
a29e5cf
@tombuildsstuff
r/app_service: documenting the identity changes
2aafc3e
@tombuildsstuff
r/synapse_workspace: documenting the identity changes
2fe1753
@tombuildsstuff
r/storage_account: documenting the identity block changes
45466a5
@tombuildsstuff
r/purview_account: documenting the identity block changes
993117e
@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Mar 23, 2022
@tombuildsstuff tombuildsstuff requested a review from a team March 23, 2022 14:54
manicminer
manicminer approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✈️

katbyte
katbyte approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

mbfrahry
mbfrahry approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 2838958 into main Mar 23, 2022
@tombuildsstuff tombuildsstuff deleted the r/3.0-todos branch March 23, 2022 16:44
tombuildsstuff added a commit that referenced this pull request Mar 23, 2022
@tombuildsstuff
updating to include #15973
e1c6403
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@katbyte katbyte katbyte approved these changes

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tombuildsstuff @manicminer @katbyte @mbfrahry