azurerm_synapse_workspace_key - can not be correctly rotated #15897
Conversation
ms-henglu
commented
Mar 21, 2022
ms-henglu
commented
| check.That(data.ResourceName).ExistsInAzure(r), | ||
| ), | ||
| }, | ||
| // CMK takes a while to activate, so validation against the plan tends to fail. |
There was a problem hiding this comment.
we should be waiting on activation then? with a state wait until it is done so this never fails?
There was a problem hiding this comment.
Hi @katbyte ,
Yes, I've added the waiting part in the first commit. And I've removed this comments in the second commit. Please take another look, thanks!
There was a problem hiding this comment.
only the the update function? what about create? shouldn't it be there too?
There was a problem hiding this comment.
Yes, you're right, I've added another commit to add it in both create and update.
|
Hi @katbyte , testcases are all passed, would you please take another look? Thanks! |
katbyte
changed the title
|
This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
