-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix import a connected synapse workspace #15829
fix import a connected synapse workspace #15829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
36e4b21
to
2347079
Compare
Hi @katbyte , I've fixed the failed tests in synapse workspace, and I saw there're more in synapse rp, I think I'll raise another PR to fix them, because they're not related with this one. |
@ms-henglu - we can remove all and eny 3.0 flag blocks now. it seems you've made the tests
|
2347079
to
7eaa2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ms-henglu
Thanks for pushing those changes, I've left a couple of suggestions inline which I hope you don't mind but I'm going to push a commit to fix - but this otherwise LGTM 👍
Thanks!
dismissing since changes have been pushed
This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
A synapse workspace can be created from a dedicated SQL pool(formly SQL DW). And it can not perform GET aad admin/ sql aad admin operations.
To address: #9845
Fixes #9845