Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import a connected synapse workspace #15829

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Mar 15, 2022

A synapse workspace can be created from a dedicated SQL pool(formly SQL DW). And it can not perform GET aad admin/ sql aad admin operations.

To address: #9845

Fixes #9845

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of failing tests, could we please fix them up?
image

@ms-henglu ms-henglu force-pushed the ticket-13798286-fix-synapse-workspace-import branch from 36e4b21 to 2347079 Compare March 17, 2022 07:39
@github-actions github-actions bot added size/M and removed size/XS labels Mar 17, 2022
@ms-henglu
Copy link
Contributor Author

Hi @katbyte , I've fixed the failed tests in synapse workspace, and I saw there're more in synapse rp, I think I'll raise another PR to fix them, because they're not related with this one.

@ms-henglu ms-henglu requested a review from katbyte March 17, 2022 08:07
@katbyte
Copy link
Collaborator

katbyte commented Mar 22, 2022

@ms-henglu - we can remove all and eny 3.0 flag blocks now. it seems you've made the tests

[](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=270799&buildTypeId=TerraformOpenSource_TerraformProviders_AzureRMPublic_AZURERM_SERVICE_PUBLIC_SYNAPSE#)------- Stdout: -------
=== RUN   TestAccSynapseWorkspaceSecurityAlertPolicy_update
=== PAUSE TestAccSynapseWorkspaceSecurityAlertPolicy_update
=== CONT  TestAccSynapseWorkspaceSecurityAlertPolicy_update
    testcase.go:110: Step 1/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Insufficient identity blocks
        
          on terraform_plugin_test.tf line 26, in resource "azurerm_synapse_workspace" "test":
          26: resource "azurerm_synapse_workspace" "test" {
        
        At least 1 "identity" blocks are required.
--- FAIL: TestAccSynapseWorkspaceSecurityAlertPolicy_update (17.23s)
FAIL

@ms-henglu ms-henglu force-pushed the ticket-13798286-fix-synapse-workspace-import branch from 2347079 to 7eaa2a3 Compare March 22, 2022 01:47
@github-actions github-actions bot added size/XS and removed size/M labels Mar 22, 2022
@ms-henglu
Copy link
Contributor Author

Hi @katbyte , the failed tests are not introduced by this PR, so I opened another PR to fix the failed synapse testcases.
#15899

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ms-henglu

Thanks for pushing those changes, I've left a couple of suggestions inline which I hope you don't mind but I'm going to push a commit to fix - but this otherwise LGTM 👍

Thanks!

internal/services/synapse/synapse_workspace_resource.go Outdated Show resolved Hide resolved
internal/services/synapse/synapse_workspace_resource.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Mar 22, 2022
@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review March 22, 2022 10:08

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 32fc726 into hashicorp:main Mar 22, 2022
tombuildsstuff added a commit that referenced this pull request Mar 22, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to attach synapse workspace to existing SQL pool
3 participants