Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster deprecate and remove role_based_access_control block and private_link_enabled #15546

Merged
merged 7 commits into from
Mar 7, 2022
Merged

azurerm_kubernetes_cluster deprecate and remove role_based_access_control block and private_link_enabled #15546

merged 7 commits into from
Mar 7, 2022

Conversation

stephybun
Copy link
Member

Closes #11140

@stephybun stephybun requested review from tombuildsstuff and a team February 22, 2022 10:24
katbyte
katbyte approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

tombuildsstuff
tombuildsstuff suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @stephybun

Thanks for this PR - I've taken a look through and left some comments inline but on the whole this is looking good to me. The main question I've got it to check that the behavioural change here is introduced only in version 3.0 of the Azure Provider rather than beforehand, since this field is also ForceNew.

Thanks!

internal/services/containers/migration/kubernetes_cluster.go Outdated Show resolved Hide resolved
internal/services/containers/kubernetes_cluster_resource.go Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Show resolved Hide resolved
tombuildsstuff
tombuildsstuff approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.99.0 milestone Mar 7, 2022
@stephybun stephybun merged commit 5475906 into main Mar 7, 2022
@stephybun stephybun deleted the r/aks-rbac-refactor branch March 7, 2022 11:40
stephybun added a commit that referenced this pull request Mar 7, 2022
@stephybun
Update for #15546
05df1fc
@github-actions
Copy link

This functionality has been released in v2.99.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees

@stephybun stephybun

Labels
documentation service/kubernetes-cluster size/XL
Projects
None yet
Milestone
v2.99.0
Development

Successfully merging this pull request may close these issues.

role_based_access_control should default to enabled for new AKS clusters
3 participants
@stephybun @tombuildsstuff @katbyte