Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new implementation of IP filter rules for azurerm_iothub #14939

Closed
BzSpi opened this issue Jan 13, 2022 · 2 comments · Fixed by #15590
Closed

Support for new implementation of IP filter rules for azurerm_iothub #14939

BzSpi opened this issue Jan 13, 2022 · 2 comments · Fixed by #15590

Comments

@BzSpi
Copy link
Contributor

BzSpi commented Jan 13, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Microsoft has changed the implementation of IP filtering rules on the IoT Hub service. Currently, the azurerm_iothub Terraform resource uses the deprecated implementation when defining the ip_filter_rule blocks.

Related documentation: https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-ip-filter-classic

New or Affected Resource(s)

  • azurerm_iothub

Potential Terraform Configuration

The Terraform configuration might remain unchanged, however since new implementation blocks all traffic by default, we should either:

  • have a new block for the new implementation to be sure not to confuse the user
  • have a warning message on apply with an updated provider to warn the user that the traffic will now be blocked by default.

References

@github-actions
Copy link

This functionality has been released in v2.99.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants