Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add missing input and outputs for azurerm_app_service_slot #1439

Closed
kevinneufeld opened this issue Jun 25, 2018 · 6 comments

Comments

@kevinneufeld
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

azurerm_app_service_slot would be great to have the following input and outputs :

Inputs:

  • identity

Outputs:

  • identity
  • site_credential

New or Affected Resource(s)

  • azurerm_app_service as reference
  • azurerm_app_service_slot

Potential Terraform Configuration

resource "azurerm_app_service_slot" "test" {
  name                = "${random_id.server.hex}"
  app_service_name    = "${azurerm_app_service.test.name}"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  app_service_plan_id = "${azurerm_app_service_plan.test.id}"

  site_config {
    dotnet_framework_version = "v4.0"
  }

  app_settings {
    "SOME_KEY" = "some-value"
  }

  connection_string {
    name  = "Database"
    type  = "SQLServer"
    value = "Server=some-server.mydomain.com;Integrated Security=SSPI"
  }
}

output "slot_site_credentials_username"{
   value = "${azurerm_app_service_slot.test.site_credential.0.username}"
}
output "slot_site_credentials_password"{
   value = "${azurerm_app_service_slot.test.site_credential.0.password}"
}

References

@tombuildsstuff
Copy link
Contributor

hey @kevinneufeld

Thanks for opening this issue - this functionality has previously been requested in #1268 and #1104 - so that we don't have multiple issues open tracking the same thing I'm going to close this issue in favour of those issues above.

Thanks!

@Leon99
Copy link

Leon99 commented Dec 3, 2018

@tombuildsstuff Please forgive me if I'm missing something, but neither of the issues you referenced mentions implementing site_credential output for azurerm_app_service_slot.

@tombuildsstuff
Copy link
Contributor

@Leon99 the site_credential block is the SCM block - given the App Service and App Service Slot resources share a bunch of common logic we can add it to both in #1104 :)

@Leon99
Copy link

Leon99 commented Dec 3, 2018

Sounds good but I still feel like I'm missing something :) site_credential currently works just fine for App Services but not for the slots. #1104 is about adding support for more SCM types. So what's the link between supporting more SCM types and site_credential for slots? Also, if you're saying that they share a lot (expectedly), what's the problem with supporting it specifically for slots?

@tombuildsstuff
Copy link
Contributor

@Leon99 sure, it'd be possible to add support for the existing functionality prior to #1104 - but given #1104 involves updating both resources & adding tests anyway, we don't plan to add it before those enhancements are added (although, we'd certainly accept a community contribution for it in the interim 😄)

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants