azurerm_kubernetes_node_pool remove Computed on node_taints and eviction_policy
#14378
Conversation
…nt and eviction_policy
There was a problem hiding this comment.
hey @stephybun
Taking a look through I've left one comment inline but if we can fix that up then this should otherwise be goos to go 👍
Thanks!
| @@ -105,6 +105,8 @@ The following arguments are supported: | |||
|
|
|||
| * `node_taints` - (Optional) A list of Kubernetes taints which should be applied to nodes in the agent pool (e.g `key=value:NoSchedule`). Changing this forces a new resource to be created. | |||
|
|
|||
| ~> **Note:** Node Taints control the behaviour of the Node Pool, as such they must be specified and reconciled as required. | |||
There was a problem hiding this comment.
this is true of all attributes? perhaps it's worth a comment in the schema instead?
| ~> **Note:** Node Taints control the behaviour of the Node Pool, as such they must be specified and reconciled as required. |
|
This functionality has been released in v2.88.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Reverting #14030.
After an internal discussion the conclusion was reached that these two fields should not be set to
Computed. Sincenode_taintsplay a pivotal role in how a cluster behaves and functions and the behaviour set byeviction_policyhas a direct effect on billing and any persistent data used within the cluster, these should be explicitly set and reconciled by the user to avoid any unpleasant surprises and potentially obscure behaviour of the cluster.