Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource: azurerm_app_service_public_certificate #14337

Merged

Conversation

jan-mrm
Copy link
Contributor

@jan-mrm jan-mrm commented Nov 24, 2021

Hey,
this pull request adds a new resource for adding public certificates to app services (and function apps).
It closes #7697

Both added acctests pass:


$ make acctests SERVICE='web' TESTARGS='-run=TestAccAppServicePublicCertificate_basicAppService' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/web -run=TestAccAppServicePublicCertificate_basicAppService -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAppServicePublicCertificate_basicAppService
=== PAUSE TestAccAppServicePublicCertificate_basicAppService
=== CONT  TestAccAppServicePublicCertificate_basicAppService
--- PASS: TestAccAppServicePublicCertificate_basicAppService (143.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   144.905s

$ make acctests SERVICE='web' TESTARGS='-run=TestAccAppServicePublicCertificate_basicFunctionApp' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/web -run=TestAccAppServicePublicCertificate_basicFunctionApp -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAppServicePublicCertificate_basicFunctionApp
=== PAUSE TestAccAppServicePublicCertificate_basicFunctionApp
=== CONT  TestAccAppServicePublicCertificate_basicFunctionApp
--- PASS: TestAccAppServicePublicCertificate_basicFunctionApp (164.55s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/web   166.103s

Feedback is much appreciated :)


Side note:
make generate did create 3 additional files which I did not push in this PR because they are unrelated: cassandra_cluster_id_test.go, cassandra_datacenter_id.go, cassandra_datacenter_id_test.go in folder /internal/services/cosmos/validate/

@katbyte katbyte added this to the v2.87.0 milestone Nov 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jan-mrm - LGTM 🏗️

@katbyte katbyte merged commit 791a1dd into hashicorp:main Nov 25, 2021
katbyte added a commit that referenced this pull request Nov 25, 2021
@github-actions
Copy link

This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for App Service Public Certificates
2 participants