Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to create azurerm_monitor_diagnostic_setting logs by category GROUP #14333

Closed
guywood13 opened this issue Nov 24, 2021 · 6 comments
Closed

Comments

@guywood13
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

MS have just introduced category groups for diagnostic settings. See refs for documentation. It would be great if we could add these category groups rather than having to specify individual categories or loop through a data source/list. This can now be seen in the Portal for app services under Diagnostic Settings.

New or Affected Resource(s)

  • azurerm_monitor_diagnostic_setting

Potential Terraform Configuration

resource "azurerm_monitor_diagnostic_setting" "example" {
  name               = "example"
  target_resource_id = data.azurerm_key_vault.example.id
  storage_account_id = data.azurerm_storage_account.example.id

  log {
    category_group = "AllLogs"
    enabled  = true

    retention_policy {
      enabled = false
    }
  }

References

@xiaxyi
Copy link
Contributor

xiaxyi commented Jan 13, 2022

working on it

@benjamin37
Copy link
Contributor

Hi @xiaxyi,

do you have an expected time of arrival of your PR? We also rely on this feature. If it will take some time, we could also provide the PR for this.

Kind regards
Benjamin

@benjamin37
Copy link
Contributor

Just saw that the api version in azure-sdk-for-go lacks behind. So the azure-sdk-for-go has to be updated first in order to get this feature in the azurerm provider. CategoryGroup was introduced in api version 2021-05-01, see Azure api documentation. Please see the following references in the azure-sdk-for-go

@doronha
Copy link

doronha commented Jan 24, 2022

Is there any workaround that can be used from TF ?

@manfred0191
Copy link

Any idea when this will be implemented ??

@magodo magodo closed this as completed Aug 30, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants