Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_synapse_workspace - Fix nilpointer for sql_aad_admin #14275

Merged
merged 2 commits into from
Nov 22, 2021
Merged

azurerm_synapse_workspace - Fix nilpointer for sql_aad_admin #14275

merged 2 commits into from
Nov 22, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Nov 19, 2021 •
edited
Loading

Fixes #14272

  • Acceptance Test for Synapse AAD Admin and Synapse SQL AAD Admin

aristosvo
aristosvo commented Nov 19, 2021
View reviewed changes
Copy link
Collaborator Author

@aristosvo aristosvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough to fix just that reference

Edit: it was, twice the same object, naming was still a bit confusing though

internal/services/synapse/synapse_workspace_resource.go Show resolved Hide resolved
@aristosvo aristosvo marked this pull request as draft November 19, 2021 16:42
@github-actions github-actions bot added size/M and removed size/XS labels Nov 20, 2021
@aristosvo
Copy link
Collaborator Author 

 TF_ACC=1 go test -v ./internal/services/synapse -run=TestAccSynapseWorkspace_update -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSynapseWorkspace_update
=== PAUSE TestAccSynapseWorkspace_update
=== CONT  TestAccSynapseWorkspace_update
--- PASS: TestAccSynapseWorkspace_update (962.88s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/synapse

@aristosvo aristosvo marked this pull request as ready for review November 20, 2021 10:27
tombuildsstuff
tombuildsstuff approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.87.0 milestone Nov 22, 2021
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-11-22 at 11 25 53

@tombuildsstuff tombuildsstuff merged commit 2500c46 into hashicorp:main Nov 22, 2021
tombuildsstuff added a commit that referenced this pull request Nov 22, 2021
@tombuildsstuff
updating to include #14275
5b57015
@github-actions
Copy link

This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/synapse size/M
Projects
None yet
Milestone
v2.87.0
Development

Successfully merging this pull request may close these issues.

The terraform-provider-azurerm_v2.86.0_x5.exe plugin crashed!
3 participants
@aristosvo @tombuildsstuff @katbyte