Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_cassandra_datacenter - add availability zones flag #14235

Merged
merged 1 commit into from
Nov 17, 2021
Merged

azurerm_cosmosdb_cassandra_datacenter - add availability zones flag #14235

merged 1 commit into from
Nov 17, 2021

Conversation

TheovanKraay
Copy link
Contributor

No description provided.

@WodansSon WodansSon changed the title add availability zones flag azurerm_cosmosdb_cassandra_datacenter - add availability zones flag Nov 17, 2021
@WodansSon WodansSon added this to the v2.86.0 milestone Nov 17, 2021
WodansSon
WodansSon approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheovanKraay, thanks for the PR! LGTM! 🚀

katbyte
katbyte reviewed Nov 17, 2021
View reviewed changes
internal/services/cosmos/cosmosdb_cassandra_datacenter_resource.go
@@ -81,6 +81,11 @@ func resourceCassandraDatacenter() *pluginsdk.Resource {
Optional: true,
ValidateFunc: validation.IntBetween(1, 10),
},
"availability_zones": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make this

Suggested change
"availability_zones": {
"availability_zones_enabled": {

@WodansSon
Copy link
Collaborator

@katbyte due to time zone shifts... can we merge this PR and I will open another one to change the attribute name?

katbyte
katbyte approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me @WodansSon !

@WodansSon WodansSon merged commit d5300a9 into hashicorp:main Nov 17, 2021
WodansSon added a commit that referenced this pull request Nov 17, 2021
@WodansSon
updating to include #14235
47fb79e
@WodansSon WodansSon mentioned this pull request Nov 17, 2021
Merged
@katbyte
Copy link
Collaborator

katbyte commented Nov 18, 2021

new PR #14237

@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/cosmosdb size/XS
Projects
None yet
Milestone
v2.86.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TheovanKraay @WodansSon @katbyte