Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TLS default to 1.2 behind 3.0 feature flag. #14229

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Set TLS default to 1.2 behind 3.0 feature flag. #14229

merged 2 commits into from
Nov 19, 2021

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Nov 17, 2021

This PR sets the default value for all TLS specific properties in the provider to 1.2 behind the feature toggle ThreePointOh().

Note: azurerm_logic_app_standard also has a TLS property that needs the default set but after an internal discussion that will be handled in a separate PR.

Update: The logic app service defaults to 1.2 already.

Groundwork for #10276

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun! LGTM 🏗️

@katbyte katbyte modified the milestones: v2.86.0, v2.87.0 Nov 19, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stephybun stephybun merged commit 214433d into main Nov 19, 2021
@stephybun stephybun deleted the f/tls-default branch November 19, 2021 08:14
stephybun added a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants