-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function slot WEBSITE_CONTENTSHARE secretly changes #14211
Conversation
@jackofallops the real changes to apply are in the file:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @uolter - Apologies for the delay. Thanks for this PR.
It looks mostly good, just a couple comments that need removing. Also, could you remove the unrelated files from the PR? Once that's addressed, I can authorise the workflows and get this through testing.
Thanks again!
@jackofallops thanks for coming back to me. I've applied all changes you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick updates @uolter, this LGTM now 👍
This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is aiming to fix the issue reported here:
fixes #14206