Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure Files Multi-Channel #13715

Open
stimms opened this issue Oct 13, 2021 · 1 comment
Open

Support for Azure Files Multi-Channel #13715

stimms opened this issue Oct 13, 2021 · 1 comment
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/storage

Comments

@stimms
Copy link

stimms commented Oct 13, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

For Azure Files a new feature recently became available to allow for SMB 3 clients to leverage multi-channel to improve performance on premium file storage.

https://azure.microsoft.com/en-us/updates/smb-multichannel-azure-files-generally-available/

New or Affected Resource(s)

  • azurerm_storage_account.smb

Potential Terraform Configuration

This new flag seems to make the most sense in the already defined smb block where it can be an optional property. By default in Azure this flag is false so it makes sense to me that if the parameter is not passed it defaults to false.

resource "azurerm_storage_account" "filestorage" {
  name                                  = "catpictures"
  resource_group_name       = var.resource_group_name
  location                             = var.resource_group_location
  account_tier                       = "Premium"
  account_replication_type  = "ZRS"
  tags                      = var.tags
  enable_https_traffic_only = true
  min_tls_version           = "TLS1_2"
  account_kind              = "FileStorage"
  access_tier               = "Hot"
  smb { 
      multi_channel           = true   <---- here
   }
}

References

@dhirschfeld
Copy link
Contributor

Has this now been resolved by #17999?
i.e. can this be closed as completed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/storage
Projects
None yet
Development

No branches or pull requests

3 participants