Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory: Support for identity = SystemAssiged,UserAssigned #13473

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 23, 2021

Fixes #13471

AccTest

❯ make acctests SERVICE='datafactory' TESTARGS='-run=TestAccDataFactory_systemAssignedUserAssignedIdentity'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/datafactory -run=TestAccDataFactory_doubleIdentity -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataFactory_systemAssignedUserAssignedIdentity
=== PAUSE TestAccDataFactory_systemAssignedUserAssignedIdentity
=== CONT  TestAccDataFactory_systemAssignedUserAssignedIdentity
--- PASS: TestAccDataFactory_systemAssignedUserAssignedIdentity (169.36s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/datafactory   170.932s

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 🌿

@katbyte katbyte merged commit 4a71040 into hashicorp:main Sep 23, 2021
@katbyte katbyte added this to the v2.78.0 milestone Sep 23, 2021
katbyte added a commit that referenced this pull request Sep 23, 2021
@github-actions
Copy link

This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_data_factory doesn't support SystemAssigned, UserAssigned for identity type (validation issue)
2 participants