Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb: Support for adding/replacing frontend_ip_configuration with availability_zone #13305

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 10, 2021

Fixes #13017

Acceptance Tests:

❯ make acctests SERVICE='loadbalancer' TESTARGS='-run=TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/loadbalancer -run=TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone
=== PAUSE TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone
=== CONT  TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone
--- PASS: TestAccAzureRMLoadBalancer_updatefrontEndConfigsWithZone (539.04s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loadbalancer  541.863s

@github-actions github-actions bot added size/M and removed size/XS labels Sep 10, 2021
@aristosvo aristosvo marked this pull request as ready for review September 10, 2021 12:36
@katbyte katbyte added this to the v2.77.0 milestone Sep 13, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 💯

@katbyte katbyte merged commit 64dd95a into hashicorp:main Sep 13, 2021
katbyte added a commit that referenced this pull request Sep 13, 2021
@github-actions
Copy link

This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_lb always recreates load balancer resources when adding a new frontend_ip_configuration
2 participants