New Resource: azurerm_key_vault_managed_storage_account and azurerm_key_vault_managed_storage_account_sas_token_definition

[aristosvo]

Takes over from #11579. Big shoutout and thanks to @MattiasAng for the first implementation which I only optimised 👍🏽

Fixes #4659

[aristosvo]

@katbyte Fixes added based on your review on #11579 plus some small consistency improvements, especially for the errors.

Only unknown to me is if the service principal has enough privileges to be used for the azuread provider, but based on other services I assumed it does.

Acceptance Tests are passing:

❯ make acctests SERVICE='keyvault' TESTARGS='-run=TestAccKeyVaultManagedStorageAccount'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/keyvault -run=TestAccKeyVaultManagedStorageAccount -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKeyVaultManagedStorageAccountSasTokenDefinition_basic
=== PAUSE TestAccKeyVaultManagedStorageAccountSasTokenDefinition_basic
=== RUN   TestAccKeyVaultManagedStorageAccountSasTokenDefinition_requiresImport
=== PAUSE TestAccKeyVaultManagedStorageAccountSasTokenDefinition_requiresImport
=== RUN   TestAccKeyVaultManagedStorageAccountSasTokenDefinition_complete
=== PAUSE TestAccKeyVaultManagedStorageAccountSasTokenDefinition_complete
=== RUN   TestAccKeyVaultManagedStorageAccountSasTokenDefinition_update
=== PAUSE TestAccKeyVaultManagedStorageAccountSasTokenDefinition_update
=== RUN   TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery
=== PAUSE TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery
=== RUN   TestAccKeyVaultManagedStorageAccount_basic
=== PAUSE TestAccKeyVaultManagedStorageAccount_basic
=== RUN   TestAccKeyVaultManagedStorageAccount_requiresImport
=== PAUSE TestAccKeyVaultManagedStorageAccount_requiresImport
=== RUN   TestAccKeyVaultManagedStorageAccount_complete
=== PAUSE TestAccKeyVaultManagedStorageAccount_complete
=== RUN   TestAccKeyVaultManagedStorageAccount_update
=== PAUSE TestAccKeyVaultManagedStorageAccount_update
=== RUN   TestAccKeyVaultManagedStorageAccount_recovery
=== PAUSE TestAccKeyVaultManagedStorageAccount_recovery
=== CONT  TestAccKeyVaultManagedStorageAccountSasTokenDefinition_basic
=== CONT  TestAccKeyVaultManagedStorageAccount_requiresImport
=== CONT  TestAccKeyVaultManagedStorageAccountSasTokenDefinition_update
=== CONT  TestAccKeyVaultManagedStorageAccountSasTokenDefinition_complete
=== CONT  TestAccKeyVaultManagedStorageAccount_basic
=== CONT  TestAccKeyVaultManagedStorageAccount_recovery
=== CONT  TestAccKeyVaultManagedStorageAccount_update
=== CONT  TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery
--- PASS: TestAccKeyVaultManagedStorageAccountSasTokenDefinition_basic (258.68s)
=== CONT  TestAccKeyVaultManagedStorageAccount_complete
--- PASS: TestAccKeyVaultManagedStorageAccountSasTokenDefinition_complete (259.10s)
=== CONT  TestAccKeyVaultManagedStorageAccountSasTokenDefinition_requiresImport
--- PASS: TestAccKeyVaultManagedStorageAccount_basic (263.31s)
--- PASS: TestAccKeyVaultManagedStorageAccount_requiresImport (272.82s)
--- PASS: TestAccKeyVaultManagedStorageAccountSasTokenDefinition_update (337.96s)
--- PASS: TestAccKeyVaultManagedStorageAccount_update (353.51s)
--- PASS: TestAccKeyVaultManagedStorageAccount_complete (237.05s)
--- PASS: TestAccKeyVaultManagedStorageAccountSasTokenDefinition_requiresImport (250.49s)
--- PASS: TestAccKeyVaultManagedStorageAccountSasTokenDefinition_recovery (519.47s)
--- PASS: TestAccKeyVaultManagedStorageAccount_recovery (520.03s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/keyvault      521.596s

[mbfrahry]

LGTM!

[github-actions]

This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.