-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_data_factory_trigger_schedule supports schedule and description #13243
azurerm_data_factory_trigger_schedule supports schedule and description #13243
Conversation
ms-henglu
commented
Sep 7, 2021
•
edited
Loading
edited
711f521
to
53b36af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @ms-henglu, tests look good, just a few minor remarks and some suggestions for the docs. Once those are addressed then this LGTM 👍🏼
internal/services/datafactory/data_factory_trigger_schedule_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_trigger_schedule_resource.go
Outdated
Show resolved
Hide resolved
internal/services/datafactory/data_factory_trigger_schedule_resource.go
Outdated
Show resolved
Hide resolved
@katbyte @stephybun Hi all, thanks for code review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu - LGTM 🍰
This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |