Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_trigger_schedule supports schedule and description #13243

Merged

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Sep 7, 2021

=== RUN   TestAccDataFactoryTriggerSchedule_basic
=== PAUSE TestAccDataFactoryTriggerSchedule_basic
=== CONT  TestAccDataFactoryTriggerSchedule_basic
--- PASS: TestAccDataFactoryTriggerSchedule_basic (213.63s)
=== RUN   TestAccDataFactoryTriggerSchedule_complete
=== PAUSE TestAccDataFactoryTriggerSchedule_complete
=== CONT  TestAccDataFactoryTriggerSchedule_complete
--- PASS: TestAccDataFactoryTriggerSchedule_complete (388.00s)
=== RUN   TestAccDataFactoryTriggerSchedule_schedule
=== PAUSE TestAccDataFactoryTriggerSchedule_schedule
=== CONT  TestAccDataFactoryTriggerSchedule_schedule
--- PASS: TestAccDataFactoryTriggerSchedule_schedule (213.27s)
PASS

@ms-henglu ms-henglu force-pushed the ticket-1869764-schedule-trigger-enhancement branch from 711f521 to 53b36af Compare September 7, 2021 04:08
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @ms-henglu, tests look good, just a few minor remarks and some suggestions for the docs. Once those are addressed then this LGTM 👍🏼

@ms-henglu
Copy link
Contributor Author

@katbyte @stephybun Hi all, thanks for code review!
I've added a commit according to your suggestions, please take another look, thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🍰

@katbyte katbyte added this to the v2.76.0 milestone Sep 9, 2021
@katbyte katbyte merged commit 9a4449b into hashicorp:main Sep 9, 2021
katbyte added a commit that referenced this pull request Sep 9, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants