Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for local_authentication_disabled in azurerm_cosmosdb_account #13237

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

shibayan
Copy link
Contributor

@shibayan shibayan commented Sep 4, 2021

Close #13184

Acctests result

TF_ACC=1 go test -v ./internal/services/cosmos -run=TestAccCosmosDBAccount_localAuthenticationDisabled -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccCosmosDBAccount_localAuthenticationDisabled
=== PAUSE TestAccCosmosDBAccount_localAuthenticationDisabled
=== CONT  TestAccCosmosDBAccount_localAuthenticationDisabled
--- PASS: TestAccCosmosDBAccount_localAuthenticationDisabled (1133.39s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/cosmos        (cached)

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shibayan aside from the one remark this LGTM 👍🏼

internal/services/cosmos/cosmosdb_account_resource.go Outdated Show resolved Hide resolved
@shibayan shibayan requested a review from stephybun September 7, 2021 10:08
@stephybun stephybun merged commit 5c74f7c into hashicorp:main Sep 7, 2021
@stephybun stephybun added this to the v2.76.0 milestone Sep 7, 2021
stephybun added a commit that referenced this pull request Sep 7, 2021
@shibayan shibayan deleted the cosmos-local-auth branch September 9, 2021 13:45
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for local_authentication_disabled in azurerm_cosmosdb_account
2 participants