-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_network_gateway_resource - Allow multiple vpn auth types #13228
Conversation
…operty and new validation
…operty and new validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have some test failures:
------ Stdout: -------
=== RUN TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
=== PAUSE TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
=== CONT TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
testcase.go:88: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_virtual_network_gateway.test will be updated in-place
~ resource "azurerm_virtual_network_gateway" "test" {
id = "/subscriptions/*******/resourceGroups/acctestRG-210903183213257255/providers/Microsoft.Network/virtualNetworkGateways/acctestvng-210903183213257255"
name = "acctestvng-210903183213257255"
# (9 unchanged attributes hidden)
~ vpn_client_configuration {
~ vpn_auth_types = [
- "AAD",
]
# (5 unchanged attributes hidden)
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth (1767.34s)
FAIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @catriona-m - LGTM 🚀
This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixes #11413