Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_resource - Allow multiple vpn auth types #13228

Merged
merged 7 commits into from
Sep 9, 2021

Conversation

catriona-m
Copy link
Member

fixes #11413

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have some test failures:

------ Stdout: -------
=== RUN   TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
=== PAUSE TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
=== CONT  TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth
    testcase.go:88: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # azurerm_virtual_network_gateway.test will be updated in-place
          ~ resource "azurerm_virtual_network_gateway" "test" {
                id                         = "/subscriptions/*******/resourceGroups/acctestRG-210903183213257255/providers/Microsoft.Network/virtualNetworkGateways/acctestvng-210903183213257255"
                name                       = "acctestvng-210903183213257255"
                # (9 unchanged attributes hidden)
        
        
        
              ~ vpn_client_configuration {
                  ~ vpn_auth_types       = [
                      - "AAD",
                    ]
                    # (5 unchanged attributes hidden)
                }
                # (2 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccVirtualNetworkGateway_vpnClientConfigAzureAdAuth (1767.34s)
FAIL

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m - LGTM 🚀

@katbyte katbyte added this to the v2.76.0 milestone Sep 9, 2021
@katbyte katbyte merged commit f8d3717 into main Sep 9, 2021
@katbyte katbyte deleted the cm/vpn_config_auth_type branch September 9, 2021 01:24
catriona-m added a commit that referenced this pull request Sep 9, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_network_gateway does not allow multiple vpn_client_configuration blocks
3 participants