Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charset and collation of azurerm_postgresql_flexible_server_database to optional #13110

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Aug 24, 2021

Service team confirmed there is a change on Postgresql Flexible Server Database. Now the charset property and the collation property are optional. So it has to update them in TF accordingly.

--- PASS: TestAccPostgresqlFlexibleServerDatabase_basic (500.55s)
--- PASS: TestAccPostgresqlFlexibleServerDatabase_withoutCharsetAndCollation (515.51s)
--- PASS: TestAccPostgresqlFlexibleServerDatabase_requiresImport (539.15s)
--- PASS: TestAccPostgresqlFlexibleServerDatabase_charsetLowercase (554.46s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@katbyte katbyte merged commit 02274a1 into hashicorp:main Aug 26, 2021
katbyte added a commit that referenced this pull request Aug 26, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants