-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore case change for aks private_dns_zone_id #13000
ignore case change for aks private_dns_zone_id #13000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ms-henglu
Thanks for this PR.
Unfortunately since this field contains both the Resource ID and the constant, this'll need to be normalised within the Read function rather than diff suppressed here.
Thanks!
@@ -601,6 +601,7 @@ func resourceKubernetesCluster() *pluginsdk.Resource { | |||
"None", | |||
}, false), | |||
), | |||
DiffSuppressFunc: suppress.CaseDifference, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be a ResourceID too, as such this only wants to be applicable for System
and None
- instead this'll want normalizing in the Read function
@tombuildsstuff , Hi, thanks for code review. I've updated the commits according to your suggestions, please take another look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ms-henglu - LGTM 🩹
This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
To address issue: #12784