Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore case change for aks private_dns_zone_id #13000

Conversation

ms-henglu
Copy link
Contributor

To address issue: #12784

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ms-henglu

Thanks for this PR.

Unfortunately since this field contains both the Resource ID and the constant, this'll need to be normalised within the Read function rather than diff suppressed here.

Thanks!

@@ -601,6 +601,7 @@ func resourceKubernetesCluster() *pluginsdk.Resource {
"None",
}, false),
),
DiffSuppressFunc: suppress.CaseDifference,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be a ResourceID too, as such this only wants to be applicable for System and None - instead this'll want normalizing in the Read function

@ms-henglu
Copy link
Contributor Author

@tombuildsstuff , Hi, thanks for code review. I've updated the commits according to your suggestions, please take another look, thanks!

@katbyte katbyte added this to the v2.73.0 milestone Aug 18, 2021
@katbyte katbyte added the bug label Aug 18, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🩹

@katbyte katbyte merged commit dc7bf58 into hashicorp:main Aug 18, 2021
katbyte added a commit that referenced this pull request Aug 18, 2021
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants