add resource "azurerm_cognitive_account_customer_managed_key"

[ms-henglu]

I re-write this CMK resource. I contacted with service team, that we can set keysource to Microsoft.CognitiveServices to disable CMK feature without re-recreate cognitive account.

[tombuildsstuff]

hi @ms-henglu

Thanks for reaching out to the service team here - I've taken a look through and left some comments inline, if we can fix those up then we should be able to take another look.

Thanks!

[tombuildsstuff]

@ms-henglu can you also reach out to the EventHub team too? Whilst I've looked to add the same fix to EventHub Namespaces here: https://github.com/terraform-providers/terraform-provider-azurerm/compare/b/eventhub-cmk - at the moment this returns Original Error: Code="BadRequest" Message="Microsoft.KeyVault is currently the only supported key source. CorrelationId: f11bcb7e-fced-d75c-ede3-c8fff76bd7c8" from the API - as such we'll need to get that fixed (or remove support for that resource)

[ms-henglu]

@tombuildsstuff , Hi, thanks for code review. I've added a commit according to your suggestions, please take another look, thanks!

[ms-henglu]

can you also reach out to the EventHub team too?

No problem.

[tombuildsstuff]

hi @ms-henglu

Thanks for pushing those changes - I've taken a look through and left a few more comments inline but this otherwise LGTM 👍

Thanks!

[ms-henglu]

@tombuildsstuff . thanks! I've added a commit to fix them, please take another look, thanks!

[katbyte]

@ms-henglu - seeing a test failure:

------- Stdout: -------
=== RUN   TestAccCognitiveAccountCustomerManagedKey_complete
=== PAUSE TestAccCognitiveAccountCustomerManagedKey_complete
=== CONT  TestAccCognitiveAccountCustomerManagedKey_complete
    testcase.go:88: Step 1/2 error: Error running apply: exit status 1
        
        Error: Provider produced inconsistent result after apply
        
        When applying changes to azurerm_cognitive_account_customer_managed_key.test,
        provider "provider[\"registry.terraform.io/hashicorp/azurerm\"]" produced an
        unexpected new value: Root resource was present, but now absent.
        
        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.
--- FAIL: TestAccCognitiveAccountCustomerManagedKey_complete (371.05s)
FAIL

[ms-henglu]

@katbyte , Hi, all passed.

[katbyte]

Thanks @ms-henglu - LGTM 🍰

[github-actions]

This functionality has been released in v2.75.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[ms-henglu]

@ms-henglu can you also reach out to the EventHub team too? Whilst I've looked to add the same fix to EventHub Namespaces here: https://github.com/terraform-providers/terraform-provider-azurerm/compare/b/eventhub-cmk - at the moment this returns Original Error: Code="BadRequest" Message="Microsoft.KeyVault is currently the only supported key source. CorrelationId: f11bcb7e-fced-d75c-ede3-c8fff76bd7c8" from the API - as such we'll need to get that fixed (or remove support for that resource)

@tombuildsstuff , Hi, I've talked with service team and they have no plan to support this feature.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.