Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for purge_soft_delete_on_destroy in azurerm_api_management #12850

Merged
merged 15 commits into from
Sep 16, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Aug 5, 2021

Fix #11061

--- PASS: TestAccApiManagement_purgeSoftDelete (743.86s)

@github-actions github-actions bot added the size/L label Aug 5, 2021
@yupwei68 yupwei68 changed the title Support for PurgeSoftDeleteOnDestroy in azurerm_api_management Support for purge_soft_delete_on_destroy in azurerm_api_management Aug 5, 2021
@yupwei68
Copy link
Contributor Author

@katbyte I've updated to solve the conflicts. Please continue reviewing.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yupwei68 - could we update the docs with this new property?

@@ -185,6 +187,12 @@ The `features` block supports the following:

---

The `api_management` block supports the following:

* `purge_soft_delete_on_destroy` - (Optional) Should the `azurerm_api_management` resources be permanently deleted (e.g. purged) when destroyed? Defaults to `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also place a note in azurerm_api_management resource referring to this feature flag.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS @yupwei68 - LGTM 🚀

@katbyte katbyte added this to the v2.77.0 milestone Sep 16, 2021
@katbyte katbyte merged commit 0331bf1 into hashicorp:main Sep 16, 2021
katbyte added a commit that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v2.77.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@akhileshnirapure
Copy link

The feature is missing any explicit action required?

cdktf/cdktf-provider-azurerm#448

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
DSollickOnyx added a commit to DSollickOnyx/terraform-provider-azurerm that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Purging Soft-Deleted API Management
5 participants