-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster - and azurerm_kubernetes_cluster_node_pool support ultra_ssd_enabled and private_cluster_public_fqdn_enabled #12780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the instructions to enable the correct features to the docs pelase?
------- Stdout: -------
=== RUN TestAccKubernetesCluster_privateClusterPublicFqdn
=== PAUSE TestAccKubernetesCluster_privateClusterPublicFqdn
=== CONT TestAccKubernetesCluster_privateClusterPublicFqdn
testcase.go:88: Step 3/6 error: Error running apply: exit status 1
Error: creating Managed Kubernetes Cluster "acctestaks210730215335635311" (Resource Group "acctestRG-aks-210730215335635311"): containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="BadRequest" Message="Feature Microsoft.ContainerService/EnablePrivateClusterPublicFQDN is not enabled. Please see https://aka.ms/aks/previews for how to enable features."
with azurerm_kubernetes_cluster.test,
on terraform_plugin_test.tf line 9, in resource "azurerm_kubernetes_cluster" "test":
9: resource "azurerm_kubernetes_cluster" "test" {
--- FAIL: TestAccKubernetesCluster_privateClusterPublicFqdn (897.16s)
FAIL
@katbyte , Hi, I've added it to the doc. Could you please take another look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ms-henglu
Thanks for pushing those changes.
I've taken a look through and left some comments inline, but it appears that some of these changes aren't necessary?
Thanks!
azurerm/internal/services/containers/kubernetes_cluster_node_pool_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/kubernetes_cluster_resource.go
Outdated
Show resolved
Hide resolved
@tombuildsstuff , Hi, thanks for code review. I've added a commit according to your suggestions. Please take another look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍰
just need conflicts resolved @ms-henglu |
@katbyte , thanks!! Conflicts resolved. |
8257a86
to
e72c323
Compare
…upport ultra_ssd_enabled and private_cluster_public_fqdn_enabled
e72c323
to
0e9e8ba
Compare
@katbyte , Hi, I rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ms-henglu
Thanks for rebasing this PR.
I've taken a look through and left some comments inline, if we can resolve those then we should be able to take another look.
Thanks!
@tombuildsstuff , Hi, I've added a commit to add default value and description, please take another look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have a test failure:
------- Stdout: -------
=== RUN TestAccKubernetesCluster_privateClusterPublicFqdn
=== PAUSE TestAccKubernetesCluster_privateClusterPublicFqdn
=== CONT TestAccKubernetesCluster_privateClusterPublicFqdn
testcase.go:88: Step 1/6 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# azurerm_kubernetes_cluster.test must be replaced
-/+ resource "azurerm_kubernetes_cluster" "test" {
- enable_pod_security_policy = false -> null
~ fqdn = "acctestaks210817063637524291-c3fdc35d.hcp.westeurope.azmk8s.io" -> (known after apply)
~ id = "/subscriptions/*******/resourcegroups/acctestRG-aks-210817063637524291/providers/Microsoft.ContainerService/managedClusters/acctestaks210817063637524291" -> (known after apply)
~ kube_admin_config = [] -> (known after apply)
+ kube_admin_config_raw = (sensitive value)
~ kube_config = [
- {
- client_certificate = "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUZIVENDQXdXZ0F3SUJBZ0lRYnRUZmZoT2p0VVdXcFVDQ0szcnR1akFOQmdrcWhraUc5dzBCQVFzRkFEQU4KTVFzd0NRWURWUVFERXdKallUQWVGdzB5TVRBNE1UY3dOakkzTWpsYUZ3MHlNekE0TVRjd05qTTNNamxhTURBeApGekFWQmdOVkJBb1REbk41YzNSbGJUcHRZWE4wWlhKek1SVXdFd1lEVlFRREV3eHRZWE4wWlhKamJHbGxiblF3CmdnSWlNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0SUNEd0F3Z2dJS0FvSUNBUUN6czh3WEMwTDRhUEpRaWNPR0FYeEEKR3ZGTExEcG0yYUI5NWMwRFZac1ZJOWxib1YwRWhQRjVKbUo3ZXh4LzNnUmZWdUYzNlgwamh5azRIK3hKSi9ZUAoyNThOeGNQbjZBZFF5S1duQThGbk5KMUtzcFgwOVJqY2ZrNkdGTlhkZVpNZDllTUVFSEM3SzYxRU5ySnFnLzFzCm9hUC9BSS9yTld4ZnNGaWppdGxlV0FML2pLdEVudFZsNlpncUdZekNCK29vOVQ1UzBIRVFEK043RXRLRHhlT0cKZHVzK0lQeWNtSHpwdzRTN2J2T1M3YUZkU0RqK1REMEpJaVhCN29wa1pCbi9GeklvQnlzRnhNSVJNLzhueXJLZwpsNTBreDMwWXBEZTVHSU45cTVSZ3RjTFMrWUwyMC9tYkZFb013d1dyQXJMbFhXaVgxbEFLeVNndzdNVDVUWUlqCjRhU3VsNkEyWEFCV3VJQ2N4dnZqeG1BZGhPb1RMRUg2dnZ6K20xVWwxTXU2dkhYS2pMRjNhd2RZbkltbXZoa1YKU1dIT3kzU0I2N3Y5UzBSQklRUG9URXNMOHNPOVg4SVA3eC80MEFjQTl3TGFiV09qTnppbkxmMXp6UktqVDEzMQo0NGRoWU15YWhkSU10VTJVc0dzYmpkYzdYOGJSeXNhNVhLTnNYZUZxalp2Y3BoL0Y2NnNyZ0Y3WWJTbDcvZUhUCjdYcHBGTk5tZGNQYVhrRnlzRXlDK29CS0tnajNSbzJFSThIeTlPdkIvem9EZUxFTkJnVmxpRGNNWkdydVpXTm8KVW1Qc2lLVDVibXZQOEN4VCt4WXg2WHgvWkswWHBDVk85SDhvempJVjhQZEIrOWFhdEVYVENrNGprZVVXUUs0eApZSTdhcU5iUzVzMklXTGdGZ25JQ3F3SURBUUFCbzFZd1ZEQU9CZ05WSFE4QkFmOEVCQU1DQmFBd0V3WURWUjBsCkJBd3dDZ1lJS3dZQkJRVUhBd0l3REFZRFZSMFRBUUgvQkFJd0FEQWZCZ05WSFNNRUdEQVdnQlQ3V3R6N3dacHIKRWV3VHhuTEo2S2RCbnFoSkhqQU5CZ2txaGtpRzl3MEJBUXNGQUFPQ0FnRUFBQXNXSUhjUVBuano5dXJIQnB4Mgp1RThjREhYQy83TFV0NUxoQkhGZjRkN0NDU21oN2VxMmc3YWh3UFlCVnZldWljS3J5MkZETjNKWlV4aVp1cW5vCm9XOHdhSDFqZStmNGlRS2xRWUl6ZDluQlpaWW83US84YUpJcE52TDhodHVUTlJiMDlEVmhpNnV3V1BjRHVOWUMKVlpwOWlxWFZ2ejdpQ2NyUk45TVB3SzRrZnh3ZHA4bFlhMDdJNHpNU1VZN3lMNFVPMlFPYVcxUXVYZm1jL0RzVwpUSG82TE5NaFM1T2FhcUh5NHV1djlDQ0NBOFBra0dqaW1nenJvaU02U0FSN1hPOG9IWmlaT2Z3UFhIaVc3dVpFCmcyVVRTV0R2c0VOT1lIcGRLRWR2dFhoSjVyeEsyTGtMNmNnbzdYTER1RFZKUEJpdHVGRGVxbkNXK2xudTRPSXQKUHRVSzNxTnlEYWRTZllPS01wNDFtdzdoQ3FUcXdzazF0ZFZia0VCd2o5VDFzaFVPWmFEaEtob055dStNOTBuRQp0djVNRGVtMG9UTUNnQVRVSVFlczQ0RHYxcHJZdWpkQnprNGdaVnBIWnJSdytmeGNOZUFoclpzbFM3MFJnL2o3CnlCNDAvc3FJZWpONzNDTW5SQVRzVko1VVlQSDZnUUtCaVpXVjVxdFZ4QXNQanZBeVN5UlZ0dlZsd0ZmOVNNREcKZmFFVy9WSURiUzZrVmxqR3JSa0JDY0hJbHJDd0pFUXNVNTY1akdsWk1Mb2R5OGlsb2JGVEphRmJDZ05RdG5CcAoxTFc2dVFnMXovQkorV3hFTDlndmI0dlFCNERnZzlBWXZKZTRtdFNjRTdaS2ZVWFlXdGVZbVozVllHTjlTcnNjCmlxOWcxejJFRnRhM0JDUGtXWTNBQUJnPQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg=="
- client_key = "LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlKS1FJQkFBS0NBZ0VBczdQTUZ3dEMrR2p5VUluRGhnRjhRQnJ4U3l3Nlp0bWdmZVhOQTFXYkZTUFpXNkZkCkJJVHhlU1ppZTNzY2Y5NEVYMWJoZCtsOUk0Y3BPQi9zU1NmMkQ5dWZEY1hENStnSFVNaWxwd1BCWnpTZFNyS1YKOVBVWTNINU9oaFRWM1htVEhmWGpCQkJ3dXl1dFJEYXlhb1A5YktHai93Q1A2elZzWDdCWW80clpYbGdDLzR5cgpSSjdWWmVtWUtobU13Z2ZxS1BVK1V0QnhFQS9qZXhMU2c4WGpobmJyUGlEOG5KaDg2Y09FdTI3emt1MmhYVWc0Ci9rdzlDU0lsd2U2S1pHUVoveGN5S0FjckJjVENFVFAvSjhxeW9KZWRKTWQ5R0tRM3VSaURmYXVVWUxYQzB2bUMKOXRQNW14UktETU1GcXdLeTVWMW9sOVpRQ3Nrb01PekUrVTJDSStHa3JwZWdObHdBVnJpQW5NYjc0OFpnSFlUcQpFeXhCK3I3OC9wdFZKZFRMdXJ4MXlveXhkMnNIV0p5SnByNFpGVWxoenN0MGdldTcvVXRFUVNFRDZFeExDL0xECnZWL0NEKzhmK05BSEFQY0MybTFqb3pjNHB5MzljODBTbzA5ZDllT0hZV0RNbW9YU0RMVk5sTEJyRzQzWE8xL0cKMGNyR3VWeWpiRjNoYW8yYjNLWWZ4ZXVySzRCZTJHMHBlLzNoMCsxNmFSVFRablhEMmw1QmNyQk1ndnFBU2lvSQo5MGFOaENQQjh2VHJ3Zjg2QTNpeERRWUZaWWczREdScTdtVmphRkpqN0lpaytXNXJ6L0FzVS9zV01lbDhmMlN0CkY2UWxUdlIvS000eUZmRDNRZnZXbXJSRjB3cE9JNUhsRmtDdU1XQ08ycWpXMHViTmlGaTRCWUp5QXFzQ0F3RUEKQVFLQ0FnRUFuYzlxamw0Y2JPdzB5QmVEZGw0OWtFcFkxbXc3eVhDYXFaVXlhaGcyZmVVaWozNXdvblJoWHNRZgp2bExLSDF5SXVIVWl3ZHh4UWM4RG1yOG1FTVNnS1NMMFZmTHo3T2R0N1RxWGhza2NnaGJKZnZ6QUJnTnIxczZ4CkJMeXRaN2JKUklsWDJJemJndk9EVUtFOEk2QlA0S00rMHNUYW5uTW0vZzF1ZWdpSWhYcUMvNHE0S1NYWFA0MVoKVExkdFRrUUhGZnJ3eFdjNXN5SlE0aGNRZWhwQmlpZEt4Ui9RMTNCdVdoZVNxOHR1NmZ2M05tVWpiK2JodnZDVworZTBTNmNDaXQ4cldDQ0xyWEVDRE1QcFp1OGNkQVR6RUNyV0puU2N4ckVIanoydnJmTmFDQmlhS0pWcllHNkZBCnVsNVZ6dTBxejVRdE14Skk3bi9pNUx3NDZycHZhcnZkZ25mOUl2SlFZTWd0aWtrYk93TThPMEc5SGM5K1VJbGMKcnFJOUl2VTd6a3hwWHBmVHoyM2NmbEkzRFdCYkVEcjFOZFhZSWdlejc5NVVYYXYydUlPRjNSaTRFR1NkZEJENQpLbWNrNmtJR2VRWnJFWG1scmROSmNFcjZiaTZYYlY3dDcrcWFoQ2FRcDhodXQ4Mk1aYktPalEwMzd5Mm5pM2hzCmlaeC9wa0lJK3d0TXpYMUZzRkhyc2RSN05nb1pveWQvL3VjUE9tNHdPQTBjWXFtdFEwRTI1VWEwTExVZW1nVEYKZkNIaExGL0psQ3JVajdPSmdkVWlTNll0SHFSU1g0MTVCNVBZTEtPN1Ird1p3dVZQQVBUYXFYaHRUbnJRb1UyMgpvNHJsOTZoOWxwRExQVXdoZ2JPREZENWcwZlRBSUhoK2RYSkJDVHkrZFFsaGhlVlNnaUVDZ2dFQkFPUkphMzlMCnRFSnJ6RVo0VjhBRFFDdTQxUlJac2VJaFhYQWNUSHI1a1JsS3Jod0R0bVZZWllEVS8wNkZGOE1PWFozZllrcmEKYUlaRGEzZlZCdkVkc3I5SWlLenZucjgrR0FJMEtJajZQNVZIRG5ORWl1Y0lTc1V2U0RwcGI4TWYrcGZwYnorUQpVc1FtMS94MllqWk4zekxtNWkwb3N5azcxNk1aanNkMWNiYVR1c0dNbGFYS0NDU244WlNFTmYrUUsySWRCQ3VlClo4ck4yWUNZTGJZWmlBRGRSYkhHZWM3UTNLdlY1d09lMXZVTHpNUDRNYnFYQ1BIMGVmTVRBQ1JHbDRLdndSWXIKczhvMlpBMU92RE90ZU95em5nelp3SkxTWTljY0FiZ1NiNWxpTjFVT3ZJT3pZNFdpSDdKZWY3cW5HdUFScDZIUApoTVZCMmV1b00zaGhqMUVDZ2dFQkFNbUVmb2NxSGt2bVhObW5PREVReGhlb0Zmdyt4TTdjb0NOMnFzWXFTRGd2ClJnaFpneEhyZFp0Rk9LRm9uR0dBVkxENmlCbzNZUlByamVOZ0ZnYjVxSktPRFBGSWlMeThHYUdPY0J6OTYxWVYKMUh5WGlsZEQzajFzRDVlNE9lclljaE05bjV0VUozbjY0eDhwY09ac2hZYTRWNW5JS21BeWRCYTV4RWhHM3ltaQp5WUVDakFwMDh3M05TMkYvMHFCMksrWmM0OGRYM3JZRUZ1Qy9DTzJWc1R5L3FBdUdTU3VmNDBzYkFENFdFVnNMCjlaTlBNdnZKazZFSFBGYmJNYlAyTmgzdDhnM2hzb05PZnl2ZFJjdlNiekhNYklYZE5mYnR0TmVpQkNQVWtGWGcKb3Vsc01ubUNDVXdHMVNGNCsvb2s4Qnk5eHRlNXZ4UFhyRmhVenhHVml6c0NnZ0VBU0QyZm9lblFBbERnbE5CUwpYSFhxNGFzYzZ0S3pndTZ5QmQ4K3FJKy9SZlNuQWtCK2dMV25jVXgxK21BTnMvRWcyT3V1ekNjdmVvVnRSYitJCjhkWkhFVmNmd1RJVzEwZ01DdTU4Z1ZSSHVMS0N0U0ZVbjJXMVc0N3AyV295THRvNHo4ZlVKNVpCU3NkTUJCMW0KV083dG1jc052ZTZxTzNzdmN2S01oenY0SHlIQ3NLc1BWQ2FKeXlmR1FBeFNsaXdHUG9jV0ljTi83dUtUV0tsUApsZGVnZlQySVo0aDZWV01zNGNmUDBncDYxWkxGV3FKNUFpWDNjN0c4d1pvYXFtQVlaQWZBSDRiMjN4KzFLNnpsCnk2aXlvcHo0Zi9LTWlTbkE1SHA5Wk1XWXdUNGVhbkUrWUtMczlJWG9aK2FWbnZod2ZjVzRlWEVVLytNbDFmZ2wKU1l2OThRS0NBUUVBcjhKbnVPdjdVS2V6QkFMYzk2NXhsK0I2akc4U3FIbTFFamxGNldDbmJKbU9zMm1lNzlvMQowUjhtcldEWVJCSHh6QW8yK3VhaVBRV04wMnJTeTNLa25HNVl5M2xBQ1p6bG5ncmxyZU9waG9PenVKZFRpWmtnCkZPSlRGemtQQ3MyTmNVcW1Fb3ZyZ25CWDk2M2xVcFFFUWVRMlEySlowMTB0ODBSQzllY2FiTzRXWWZjZXZXQVQKUFU1NUdLaXJ4RmhOSWJhUzFDTEhsR2tzcXdqemVJUysrUVVRUkR6elJLRkhWUkpQdTliemZEMktDdGxnMWtxUwpBRGlYWUFuOTU4QXVveHdOcWgzWDNMNXlISWY1Z0RRaDE0VThnZVRXVkhBdThvUFVxSXVVOTlIZFJVbWhIR2xXClFvRVRFd2E2ZndvSWdvampEUFJzdTVtNEw3S0lpQVd1VVFLQ0FRQXNzdzFrWi9JejZjZGN0MStpaWdNUDE3WHcKZ20xeHB1ODlUbm5lVEU3Z3NSRkF0bllBSXl5NWJzY3RPMWpMY0RGRTMxUDFyUk5vaC9LRndISUwyNUdJS0V4aApFNmNSU1IyR0VZM0gzb0hqQVczS2pJai92NHc5ZjNRY3ZSUXY5YlRLdjN1ZjVlTGpGcEthTDB2cTBicHdsblJRClZhUWE2c0ZFVFc4MFd2MkpQZEtPcjBZRFRDL1NuUzRrWE54S01vMWYvN3hMZDNJZlljSlhuSGxwUG9wd2ViMXUKUTJyQWZmaW1vZmVscHV2bmwyUmp1b2wyeVplRzc2YWpla0s2L0RocFJlVFk0RkxBbVI2SWt6RkNIREJlbkFGMApjaHROOUdpUG8yMFN6VE9SMEx1dyszQ08rN2N1d2tlRXJvbTVxYU9YdmRKU05BS3NuZ2FJZVkwOE1NN0UKLS0tLS1FTkQgUlNBIFBSSVZBVEUgS0VZLS0tLS0K"
- cluster_ca_certificate = "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUU2VENDQXRHZ0F3SUJBZ0lSQUlWNlR2RVVKS1hXSW1NVlRVN0xXeW93RFFZSktvWklodmNOQVFFTEJRQXcKRFRFTE1Ba0dBMVVFQXhNQ1kyRXdJQmNOTWpFd09ERTNNRFl5TnpJNVdoZ1BNakExTVRBNE1UY3dOak0zTWpsYQpNQTB4Q3pBSkJnTlZCQU1UQW1OaE1JSUNJakFOQmdrcWhraUc5dzBCQVFFRkFBT0NBZzhBTUlJQ0NnS0NBZ0VBCnR4dkY5UUwrWExWOER0QWE0dytTU01wQ0NleXdlYURrdEVla1NpaE5SZnVMV2RwOXBPTkJFY3BoY1Z0ZGlHZmsKNFdGVzhybjZ3N3MzcENtQ2FUQU0wWHZXcGxCTC9QVnV0WVRISDVqbDFXVlhlaXZXTTczOEQyTlZYU0I2aTlWMwp0T1Bzc1RwcXRFQUZJTzh1d0h3dndkRjBab3ZUWnhQL3g2dzdEaVQvdlJ1aDBYNkV1OWNFdXE5d0gvUlJDTDMvCkNIamxlZDIvakZKMlN5dTBBTHVnQWZmWjlPYy9ER00wNGpZSUJHaUNqVjdieDhiM1lyRUQzNkRmcys3UmN6am8KeGpyS0tPSld6OUtpdFBwWXkyYVhyL2dXVU40NVFvb3Q1aDBxam1sTW5lYWJCVjc3L2h3aWNoQ2xsVGtGNktmSQo2U0hOSUFEQnN5TGpLUlVqMEFkLzBXcWdnQmlzSnBxZnBwbFIxSkQvNlp0WkE5S2h2MWtrZ250a0czY1RYc1R1CjZqU0gxdTJSeUxOQk1zV0ZrdFVMYzJRRGY5ZTFpb2RlTHFTRVYvckZFSjhvc1ZWcXkwWWxhNTk1SmtzM1JwVGwKQWw2NFJ3aGdkeGhmVWkvMUNHeDFJVXRSTkhzYS85VVdSKzcxam1kSW1OaUlsdUhpamxObEJLb3JyTFhjcUdBRQpyM2RWclduV0NwLzc2eFdFbkxpTDVkN3JmbUlDYkpFWEcxRU5TeXI2aUFrM0hCbW5DLzlBdER4cUpiTlN2bXA0CmJuQXBFZ3lqdFpYMUZoS0NJS3BsUFVURVhLTmp0aFBUdnJKUnpiUWhUQklYd2ZRaytVaHRhek8wSXQ2MjhMVlkKUWlzQnNYQ2tTQlRnandDbUI4M2p3T2hOeEt6R3BSb1IrZUJvWlFlSHRBY0NBd0VBQWFOQ01FQXdEZ1lEVlIwUApBUUgvQkFRREFnS2tNQThHQTFVZEV3RUIvd1FGTUFNQkFmOHdIUVlEVlIwT0JCWUVGUHRhM1B2Qm1tc1I3QlBHCmNzbm9wMEdlcUVrZU1BMEdDU3FHU0liM0RRRUJDd1VBQTRJQ0FRQWhNWEtqbXFTNzZqV1J1K1FmOUtTSFFtdXUKUm5QNlpza0lUV3dpbXZjVzNlbHhjR1YzbytTUkk0ZW1PRllJRStoYmJFU1lPeXJnSFVGRUVMSHA0QTM2THdrawpGbVphdE5JTHRTNm45K3F3aVN6UzBPYWtML2dvL1pab05YUTlNajBOOEJ1QkwwMUtEaVZScXlOam8rRXI1UytPCnc5SURWWldOcXRlUEJ4WXdnWmFRRkRJakx2RVZUaVNkcW1MT3lETzlTZzNuUklBcmhoZEI5ZTN6dklYOTg2QWMKczFwWU9ZNTBvTnVybjVVQ1ZqRUdLVlBjbTJ4RHIyOUZuR3l5NFJDL0hDeTZuNlluMG9UZXYrMXVLRlkwZzlpQgpodTdQaUQ3WUdZVTQ2SXhpdXNiTCtmNWZpRzlYQ3RuUmZ5VkZwTlJXd2pPVFJibXlhRGV2M0VqaFBqck42MXZQCksrNzJZUVEwRFl4TTBmVVFOSEluRlVCdHFIL2Z0YzB6cWNjRzFPbVFDU09ocFJMR0dBS3ZsVUYzcGRaekhqL1IKeUU4bzYrbXp5a2l2QXZvSnlzSFhBU3NxRllYSWZ4dkZIeWcrVXM2VmJRTDA5YytZSXpxbmFIS2d3N2k1MSt0LwphNUJrdmVkMEg0R3NoQlJKV3R6WTJGMFkxZFZuSHdvQVBJbFZEaC96TExwRjVUaVpaQmE4dk1VVUZMYnRjK1R2CjU2azdTdmJob3NzQTl2cEpmcDdUNzlRNUIvMm5SeW1WQkkyNHdJaWkrdkdBbitVUFh2SHFvZGd2OW0xU1QzYVYKZzVHbXBFcVBlWGpzZkIwUTZ6Zy80MTc3VzdnM01XT3IvTzVYT2NvV1NrZDFHblpSUU83THEwZC9QTkxNamd3aQpXeWZjS2I3cmJNSnRUQklTdXc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg=="
- host = "https://acctestaks210817063637524291-a7403f0e.47bdbe7f-bcc3-4228-a567-db77fbe77a54.privatelink.westeurope.azmk8s.io:443"
- password = "a967d15eaf37d30fb7b5d98434988b52a34f767c57832e8c0cff27ef1ed13bdc853c4984101613c904fa3fcf8ab96f02b3fba5ede7ee25ab79a4abf78fba9e8c"
- username = "clusterUser_acctestRG-aks-210817063637524291_acctestaks210817063637524291"
},
] -> (known after apply)
~ kube_config_raw = (sensitive value)
~ kubernetes_version = "1.20.7" -> (known after apply)
- local_account_disabled = false -> null
name = "acctestaks210817063637524291"
~ node_resource_group = "MC_acctestRG-aks-210817063637524291_acctestaks210817063637524291_westeurope" -> (known after apply)
~ private_cluster_public_fqdn_enabled = true -> false # forces replacement
~ private_dns_zone_id = "system" -> (known after apply)
~ private_fqdn = "acctestaks210817063637524291-a7403f0e.47bdbe7f-bcc3-4228-a567-db77fbe77a54.privatelink.westeurope.azmk8s.io" -> (known after apply)
~ private_link_enabled = true -> (known after apply)
# (5 unchanged attributes hidden)
~ addon_profile {
~ aci_connector_linux {
~ enabled = false -> (known after apply)
+ subnet_name = (known after apply)
}
~ azure_policy {
~ enabled = false -> (known after apply)
}
~ http_application_routing {
~ enabled = false -> (known after apply)
+ http_application_routing_zone_name = (known after apply)
}
~ ingress_application_gateway {
+ effective_gateway_id = (known after apply)
~ enabled = false -> (known after apply)
+ gateway_id = (known after apply)
+ gateway_name = (known after apply)
~ ingress_application_gateway_identity = [] -> (known after apply)
+ subnet_cidr = (known after apply)
+ subnet_id = (known after apply)
}
~ kube_dashboard {
~ enabled = false -> (known after apply)
}
~ oms_agent {
~ enabled = false -> (known after apply)
+ log_analytics_workspace_id = (known after apply)
~ oms_agent_identity = [] -> (known after apply)
}
}
+ auto_scaler_profile {
+ balance_similar_node_groups = (known after apply)
+ empty_bulk_delete_max = (known after apply)
+ expander = (known after apply)
+ max_graceful_termination_sec = (known after apply)
+ max_node_provisioning_time = (known after apply)
+ max_unready_nodes = (known after apply)
+ max_unready_percentage = (known after apply)
+ new_pod_scale_up_delay = (known after apply)
+ scale_down_delay_after_add = (known after apply)
+ scale_down_delay_after_delete = (known after apply)
+ scale_down_delay_after_failure = (known after apply)
+ scale_down_unneeded = (known after apply)
+ scale_down_unready = (known after apply)
+ scale_down_utilization_threshold = (known after apply)
+ scan_interval = (known after apply)
+ skip_nodes_with_local_storage = (known after apply)
+ skip_nodes_with_system_pods = (known after apply)
}
~ default_node_pool {
- enable_auto_scaling = false -> null
- enable_host_encryption = false -> null
- enable_node_public_ip = false -> null
- fips_enabled = false -> null
~ kubelet_disk_type = "OS" -> (known after apply)
- max_count = 0 -> null
~ max_pods = 110 -> (known after apply)
- min_count = 0 -> null
name = "default"
- only_critical_addons_enabled = false -> null
~ orchestrator_version = "1.20.7" -> (known after apply)
~ os_disk_size_gb = 128 -> (known after apply)
# (5 unchanged attributes hidden)
}
~ identity {
~ principal_id = "60891f1f-1464-4eb0-9767-cb6bf9e6f53b" -> (known after apply)
~ tenant_id = "*******" -> (known after apply)
# (1 unchanged attribute hidden)
}
~ kubelet_identity {
~ client_id = "69803a5c-f767-4df3-8960-f543d1857c01" -> (known after apply)
~ object_id = "61689180-7bfb-42f2-a7bf-234cf3a3b2d1" -> (known after apply)
~ user_assigned_identity_id = "/subscriptions/*******/resourceGroups/MC_acctestRG-aks-210817063637524291_acctestaks210817063637524291_westeurope/providers/Microsoft.ManagedIdentity/userAssignedIdentities/acctestaks210817063637524291-agentpool" -> (known after apply)
}
~ network_profile {
~ dns_service_ip = "10.0.0.10" -> (known after apply)
~ docker_bridge_cidr = "172.17.0.1/16" -> (known after apply)
~ load_balancer_sku = "Standard" -> "standard"
+ network_mode = (known after apply)
+ network_policy = (known after apply)
~ pod_cidr = "10.244.0.0/16" -> (known after apply)
~ service_cidr = "10.0.0.0/16" -> (known after apply)
# (2 unchanged attributes hidden)
~ load_balancer_profile {
~ effective_outbound_ips = [
- "/subscriptions/*******/resourceGroups/MC_acctestRG-aks-210817063637524291_acctestaks210817063637524291_westeurope/providers/Microsoft.Network/publicIPAddresses/4bf8e0e6-3c76-47bf-8025-05cf892d8dda",
] -> (known after apply)
~ idle_timeout_in_minutes = 0 -> (known after apply)
~ managed_outbound_ip_count = 1 -> (known after apply)
~ outbound_ip_address_ids = [] -> (known after apply)
~ outbound_ip_prefix_ids = [] -> (known after apply)
~ outbound_ports_allocated = 0 -> (known after apply)
}
}
~ role_based_access_control {
~ enabled = false -> (known after apply)
+ azure_active_directory {
+ admin_group_object_ids = (known after apply)
+ azure_rbac_enabled = (known after apply)
+ client_app_id = (known after apply)
+ managed = (known after apply)
+ server_app_id = (known after apply)
+ server_app_secret = (sensitive value)
+ tenant_id = (known after apply)
}
}
+ windows_profile {
+ admin_password = (sensitive value)
+ admin_username = (known after apply)
+ license = (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
--- FAIL: TestAccKubernetesCluster_privateClusterPublicFqdn (910.48s)
FAIL
…privateclusterpublicfqdn
@katbyte , Hi, I've fixed the test, please take another look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖
This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Tests:
To use privateClusterPublicFqdn, must register feature by this command