Handle nil values for AllowBlobPublicAccess #12689
Conversation
There was a problem hiding this comment.
hey @koikonom
Thanks for this PR.
I've taken a look through and on the whole this LGTM, but I think we should consider renaming this field in 3.0 too, so that it's explicit what it does (since this is a source of confusion right now)?
Thanks!
| if props.AllowBlobPublicAccess != nil { | ||
| allowBlobPublicAccess = *props.AllowBlobPublicAccess | ||
| } | ||
| d.Set("allow_blob_public_access", allowBlobPublicAccess) |
There was a problem hiding this comment.
I still think we need to rename this field in 3.0 to something more descriptive because it's confusing and doesn't accurately describe what it does (which is that nested items within this Account [e.g. Containers Blobs etc] can opt into being public) - maybe can_nested_items_be_public or something? The benefit of doing that is the Deprecated argument here would allow us to explain what this field actually does?
There was a problem hiding this comment.
maybe "public_nested_items_enabled"
There was a problem hiding this comment.
I think that suffers from the same issue, I think we'll need to be a little wordy to be clear here tbh, given how this is misleading at the moment?
There was a problem hiding this comment.
After further discussion with @tombuildsstuff and @redeux we decided to go with allow_nested_items_to_be_public.
koikonom
force-pushed
the
b/handle_nil_publicaccess_flag
branch
from
04ddaf9 to
d267790
Compare
koikonom
force-pushed
the
b/handle_nil_publicaccess_flag
branch
from
40072eb to
a7f32bb
Compare
|
Rebased to address conflicts. |
|
This functionality has been released in v2.75.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.