Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for downgrade AKS sku_tier without recreate #12643

Closed
tjololo opened this issue Jul 19, 2021 · 4 comments · Fixed by #12651
Closed

Support for downgrade AKS sku_tier without recreate #12643

tjololo opened this issue Jul 19, 2021 · 4 comments · Fixed by #12651

Comments

@tjololo
Copy link

tjololo commented Jul 19, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently downgrading fra Paid sku_tier to Free forces recreation of the AKS-cluster.
Enforced by this code:

			// Downgrade from Paid to Free is not supported and requires rebuild to apply
			pluginsdk.ForceNewIfChange("sku_tier", func(ctx context.Context, old, new, meta interface{}) bool {
				return new == "Free"
			}),

Also this is also adressed in comments here
Checking with wayback machine this was true ref: wayback aks uptime sla.
AKS now supports downgrade from Paid to Free ref: aks uptime sla.

Could the force new if changed for sku_tier Paid -> Free be removed to support downgrading sku_tier without recreation?

I would be happy to create a pull request on this issue

New or Affected Resource(s)

Potential Terraform Configuration

There would be no changes to the terraform configuration only the sync/plan/apply logic

References

@aristosvo
Copy link
Collaborator

I'll look into it tonight!

@github-actions
Copy link

This functionality has been released in v2.69.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tjololo
Copy link
Author

tjololo commented Jul 23, 2021

Thanks @aristosvo and @tombuildsstuff for looking into, fixing, approving, merging, closing and releasing the issue all within four days!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants