Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Customer Managed Keys for notebooks in the Azure Databricks resource #12302

Closed
alexott opened this issue Jun 21, 2021 · 5 comments

Comments

@alexott
Copy link
Contributor

alexott commented Jun 21, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Recently, Databricks has added support for customer managed keys (CMK) for managed services (notebooks, etc.). This functionality complements the CMK for DBFS Root for which there is already another issue: #9785

The ability to encrypt data with customer's keys is a requirement for many big customers of Azure Databricks.

New or Affected Resource(s)

  • azurerm_databricks_workspace

Potential Terraform Configuration

custom_parameters {
  cmk_managed_services {
    key_vault_id = azurerm_key_vault.example.id
    key_id = azurerm_key_vault_key.example.id
    key_version = azurerm_key_vault_key.example.version
  }
}

References

@WodansSon
Copy link
Collaborator

This was fixed in #12331

@alexott
Copy link
Contributor Author

alexott commented Jul 13, 2021

@WodansSon I've looked onto changes, but as I see it doesn't cover this specific issue. CMK for notebooks is a separate piece from DBFS root encryption, and exists only in pre-release version of API, not in the 2018-04-01. It allows to specify a separate key for notebooks & another for DBFS root.

Can you please re-open this issue.

thank you

@favoretti
Copy link
Collaborator

Re-opening as requested. @WodansSon can you please have a look? Thank you!

@favoretti favoretti reopened this Jul 22, 2021
@alexott
Copy link
Contributor Author

alexott commented Dec 1, 2021

it's supported now

@github-actions
Copy link

github-actions bot commented Jan 1, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants