Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for internal_load_balancing_mode on azurerm_app_service_environment_v3 #12251

Closed
haraldatbmw opened this issue Jun 17, 2021 · 9 comments · Fixed by #12932
Closed

Support for internal_load_balancing_mode on azurerm_app_service_environment_v3 #12251

haraldatbmw opened this issue Jun 17, 2021 · 9 comments · Fixed by #12932

Comments

@haraldatbmw
Copy link
Contributor

Terraform (and AzureRM Provider) Version

  • Terraform 1.0.0
  • AzureRM Provider 2.63.0

Affected Resource(s)

azurerm_app_service_environment_v3

Terraform Configuration Files

data "azurerm_virtual_network" "vnet" {
  name                = "MyVNET"
  resource_group_name = "Group-VNET"
}

resource "azurerm_subnet" "inbound" {
  name                                           = "ase-in"
  resource_group_name                            = data.azurerm_virtual_network.vnet.resource_group_name
  virtual_network_name                           = data.azurerm_virtual_network.vnet.name
  address_prefixes                               = ["10.9.88.192/27"]
  enforce_private_link_endpoint_network_policies = false
}

resource "azurerm_subnet" "outbound" {
  name                 = "ase-out"
  resource_group_name  = data.azurerm_virtual_network.vnet.resource_group_name
  virtual_network_name = data.azurerm_virtual_network.vnet.name
  address_prefixes     = ["10.9.88.224/27"]

  delegation {
    name = "delegation"
    service_delegation {
      name    = "Microsoft.Web/hostingEnvironments"
      actions = ["Microsoft.Network/virtualNetworks/subnets/action"]
    }
  }
}

resource "azurerm_resource_group" "rg" {
  name     = "ase-tf"
  location = "westeurope"
}

resource "azurerm_app_service_environment_v3" "ase" {
  name                = "myase"
  resource_group_name = azurerm_resource_group.rg.name
  subnet_id           = azurerm_subnet.outbound.id

  tags = {
    terraformed = "true"
  }
}

Expected Behaviour

When creating an "App Service Environment (preview)" via the Azure Portal the ASE inbound IP is bound into a subnet of my vnet via a private endpoint. Same behaviour is expected when creating via Terraform provider.

Actual Behaviour

The ASE created via Terraform provider created inbound connection to an external public IP address.

Steps to Reproduce

  1. terraform apply
@haraldatbmw haraldatbmw changed the title azurerm_app_service_environment_v3 does not create internal inbound connectivity azurerm_app_service_environment_v3 does not create private inbound connectivity Jun 17, 2021
@haraldatbmw
Copy link
Contributor Author

haraldatbmw commented Jun 22, 2021

I think the terraform resource azurerm_app_service_environment_v3 is missing the property internal_load_balancing_mode which was available in the predecessor.

https://github.com/Azure/azure-rest-api-specs/blob/c059fb47f87a35ce5a90631883dfba8f01a41d8e/specification/web/resource-manager/Microsoft.Web/stable/2021-01-01/CommonDefinitions.json#L81

@haraldatbmw haraldatbmw changed the title azurerm_app_service_environment_v3 does not create private inbound connectivity Support for internal_load_balancing_mode on azurerm_app_service_environment_v3 Jun 22, 2021
@adamyager
Copy link

This service goes GA next week so any ability to add this to the next release would be apprecated. Today it cannot be deployed for most use cases.

@haraldatbmw
Copy link
Contributor Author

ASEv3 is now GA - see https://azure.microsoft.com/en-us/updates/app-service-environment-v3-now-generally-available/

@orenzi-tr

This comment has been minimized.

@scuderig

This comment has been minimized.

@jackofallops
Copy link
Member

Hi all - by way of update, I have the GA update to this resource waiting on a branch, however, we're blocked on a couple SDK/API fixes that are part of this upstream PR: Azure/azure-rest-api-specs#15188. (Notably the dedicated hosts property incorrectly marked as Read Only, and support for configuring zonal resources). As soon as that's merged and made available in an SDK release, we'll get this moving.

@mcalik77
Copy link

Any news on this issue? Anybody used Arm template to create asev3?

@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.