Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure Event Hubs Namespace Premium tier #12141

Closed
joshua-hancox opened this issue Jun 9, 2021 · 5 comments
Closed

Support for Azure Event Hubs Namespace Premium tier #12141

joshua-hancox opened this issue Jun 9, 2021 · 5 comments
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/event-hubs EventHubs

Comments

@joshua-hancox
Copy link

joshua-hancox commented Jun 9, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure Event Hubs Namespace has recently added a new tier named Premium

(https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-quotas)

Currently the provider only allows for sku's Basic and Standard. Could the premium tier be added? @favoretti

New or Affected Resource(s)

  • azurerm_eventhub_namespace

Potential Terraform Configuration

resource "azurerm_eventhub_namespace" "example" {
  name                = "example-namespace"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  sku                 = "Premium"
  capacity            = 2
}
@favoretti
Copy link
Collaborator

Will look into it in a bit.

@tombuildsstuff tombuildsstuff added sdk/requires-newer-api-version This requires upgrading the version of the API being used enhancement service/event-hubs EventHubs labels Jun 10, 2021
@favoretti
Copy link
Collaborator

As discussed offline, this requires a newer API version. As soon as we're able to upgrade this can be added.

@sehgalnamit
Copy link
Contributor

sehgalnamit commented Jun 29, 2021

There is a problem in the terraform documentation
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/eventhub_namespace_customer_managed_key

resource "azurerm_eventhub_namespace" "example" {
name = "example-namespace"
location = azurerm_resource_group.example.location
resource_group_name = azurerm_resource_group.example.name
sku = "Standard"
dedicated_cluster_id = azurerm_eventhub_cluster.example.id

identity {
type = "SystemAssigned"
}
}

It does not work with Standard

2021-06-29 16:49:51 Error: creating/updating Namespace: (Name "ehn-sgrtss-dev-az1-mwrgy7" / Resource Group "rsg-sgrtss-dev-az1-mwrgy7"): performing CreateOrUpdate: namespaces.NamespacesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="BadRequest" Message="Customer-managed key encryption at rest is only available for namespaces of premium SKU or namespaces created in a Dedicated Cluster. CorrelationId: 30c70fb5-4826-fbd6-6089-3523dac06562"
2021-06-29 16:49:51

So documentation must be fixed and feature should only be included if this is being tested.

@mybayern1974
Copy link
Collaborator

I'm closing this issue by noticing PR 12695 trying to address this has been merged and released. Please suggest to reopen this issue if there are any other stories.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/event-hubs EventHubs
Projects
None yet
Development

No branches or pull requests

5 participants