Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_data_factory_linked_service_data_lake_storage_gen2" - supports property "storage_account_key" #12136

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jun 9, 2021

this linked service supports three authentication: storage_account_key, service principal, managed identity

this PR add supports for storage_account_key authentication.

Besides, according to https://docs.microsoft.com/en-us/azure/data-factory/connector-azure-data-lake-storage#linked-service-properties.

url, accountKey is required when using Account key authentication. accountKey not returned in response.
url, servicePrincipalId, servicePrincipalCredential, tenant is required when using service principal authentication
url is needed when using msi authentication.

So I added some limitation for tenant schema.
because accountKey is not returned in response, in the read function, it's hard to know whether users are using Account key authentication or msi authentication. So I removed the d.set("use_use_managed_identity", xxx).

image

@ghost ghost added the size/M label Jun 9, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 💯

@katbyte katbyte merged commit f3649f9 into hashicorp:master Jun 10, 2021
katbyte added a commit that referenced this pull request Jun 10, 2021
@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants