Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_sftp: support for hostkey related properties #11825

Merged
merged 4 commits into from
May 24, 2021
Merged

azurerm_data_factory_linked_service_sftp: support for hostkey related properties #11825

merged 4 commits into from
May 24, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented May 22, 2021

Add skip_host_key_validateion and host_key_fingerprint arguments.

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m  -run='TestAccDataFactoryLinkedServiceSFTP'
2021/05/22 13:03:13 [DEBUG] not using binary driver name, it's no longer needed
2021/05/22 13:03:13 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataFactoryLinkedServiceSFTP_basic
=== PAUSE TestAccDataFactoryLinkedServiceSFTP_basic
=== RUN   TestAccDataFactoryLinkedServiceSFTP_update
=== PAUSE TestAccDataFactoryLinkedServiceSFTP_update
=== CONT  TestAccDataFactoryLinkedServiceSFTP_basic
=== CONT  TestAccDataFactoryLinkedServiceSFTP_update
--- PASS: TestAccDataFactoryLinkedServiceSFTP_basic (117.42s)
--- PASS: TestAccDataFactoryLinkedServiceSFTP_update (162.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	164.318s

Fixes #11797

Add `skip_host_key_validateion` and `host_key_fingerprint` arguments.

Fixes #11797
@favoretti
Copy link
Collaborator Author

image

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti Thanks for this PR!
I've taken a look through and left some comments inline. Besides which, does it make sense to add test cases for the new properties?

@ghost ghost added size/XS and removed size/S labels May 24, 2021
@magodo
Copy link
Collaborator

magodo commented May 24, 2021

@favoretti LGTM 👍 Thank you!

image

@magodo magodo changed the title azurerm_data_factory_linked_service_sftp: Add hostkey attributes azurerm_data_factory_linked_service_sftp: support for hostkey related properties May 24, 2021
@magodo magodo merged commit 3007cfd into hashicorp:master May 24, 2021
magodo added a commit that referenced this pull request May 24, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_data_factory_linked_service_sftp -- Unable to connect to SFTP server
2 participants