-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: azurerm_eventhub_cluster
#11763
Conversation
New data source: `azurerm_eventhub_cluster`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for this PR :)
I've taken a look through and left a couple of comments inline but if we can fix those up then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/eventhub/eventhub_cluster_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventhub/eventhub_cluster_data_source.go
Outdated
Show resolved
Hide resolved
…e.go Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a failing test:
Error: Reference to undeclared resource
on terraform_plugin_test.tf line 19, in data "azurerm_eventhub_cluster" "test":
19: name = azurerm_eventhub.test.name
A managed resource "azurerm_eventhub" "test" has not been declared in the
🥳 |
Fixed it all up, running acceptance test as we speak, will just take 4 hours while waiting for cluster to be destroyed. |
This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.60.0"
}
# ... other configuration ... |
Co-authored-by: Tom Harvey <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
New data source:
azurerm_eventhub_cluster