Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_databricks_workspace - Fix propagation of tags to connected resources #11405

Merged
merged 5 commits into from
Apr 21, 2021
Merged

azurerm_databricks_workspace - Fix propagation of tags to connected resources #11405

merged 5 commits into from
Apr 21, 2021

Conversation

WodansSon
Copy link
Collaborator

fixes #11395

@WodansSon WodansSon added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/databricks labels Apr 21, 2021
@WodansSon WodansSon added this to the v2.57.0 milestone Apr 21, 2021
@WodansSon WodansSon requested a review from katbyte April 21, 2021 06:39
@ghost ghost added the size/S label Apr 21, 2021
katbyte
katbyte approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment this LGTM 👍

azurerm/internal/services/databricks/databricks_workspace_resource.go Show resolved Hide resolved
@WodansSon WodansSon mentioned this pull request Apr 21, 2021
Closed
@ghost ghost added size/XS and removed size/S labels Apr 21, 2021
@WodansSon
Copy link
Collaborator Author

The two test cases that failed are known issues:
image

@WodansSon WodansSon merged commit fe1e86f into master Apr 21, 2021
@WodansSon WodansSon deleted the b-adb-icm branch April 21, 2021 22:39
WodansSon added a commit that referenced this pull request Apr 21, 2021
@WodansSon
Update to include #11405
ef782c1
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@JeetSharan JeetSharan JeetSharan approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug service/databricks size/XS upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Milestone
v2.57.0
Development

Successfully merging this pull request may close these issues.

azurerm_databricks_workspace tags argument always forces replacement of databricks_workspace resource
4 participants
@WodansSon @tombuildsstuff @katbyte @JeetSharan