Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_mssql_job_credential #11363

Merged
merged 12 commits into from
Apr 24, 2021

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Apr 19, 2021

Job Credential resource as part of the Elastic Job Agents.

see: GH-11248

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @r0bnet - Many thanks for this PR, looking mostly good, but I've left a few suggestions for making use of the generated ID code. We're aiming to use these throughout the provider, so newly introduced resources can make use of them on Create (we're working through existing resources slowly as they will need state migrations, hence largely looking like only in Read).
Thanks again!

@jackofallops jackofallops changed the title [RESOURCE] Mssql Elastic Job Credential New Resource: azurerm_mssql_job_credential Apr 19, 2021
@jackofallops jackofallops added this to the v2.57.0 milestone Apr 19, 2021
@r0bnet r0bnet requested a review from jackofallops April 19, 2021 13:41
@r0bnet
Copy link
Contributor Author

r0bnet commented Apr 19, 2021

Thanks @jackofallops. I committed your suggestions. Hope it's good to go now 👍

@ghost ghost removed the waiting-response label Apr 19, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing but this otherwise LGTM - thanks for pushing those changes @r0bnet

@katbyte katbyte merged commit 831cb75 into hashicorp:master Apr 24, 2021
katbyte added a commit that referenced this pull request Apr 24, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@r0bnet r0bnet deleted the mssql-job-credential branch May 3, 2021 06:11
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants