-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_mssql_job_credential
#11363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @r0bnet - Many thanks for this PR, looking mostly good, but I've left a few suggestions for making use of the generated ID code. We're aiming to use these throughout the provider, so newly introduced resources can make use of them on Create (we're working through existing resources slowly as they will need state migrations, hence largely looking like only in Read).
Thanks again!
azurerm/internal/services/mssql/mssql_job_credential_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_job_credential_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_job_credential_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mssql/mssql_job_credential_resource.go
Outdated
Show resolved
Hide resolved
azurerm_mssql_job_credential
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
Co-authored-by: Steve <[email protected]>
Thanks @jackofallops. I committed your suggestions. Hope it's good to go now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor thing but this otherwise LGTM - thanks for pushing those changes @r0bnet
azurerm/internal/services/mssql/mssql_job_credential_resource.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <[email protected]>
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Job Credential resource as part of the Elastic Job Agents.
see: GH-11248