Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hpc_cache_nfs_target - support for access_policy_name #11186

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 1, 2021

Add access_policy_name to azurerm_hpc_cache_nfs_target. The existing resources are guaranteed to use the access policy as default, so making it the default value should make no breaking change or unnecessary plan diff. For the same reason, I've updated the schema for the same property for azurerm_hpc_cache_blob_target.

Test Result

💤 make testacc TEST=./azurerm/internal/services/hpccache TESTARGS='-run "TestAccHPCCacheNFSTarget_accessPolicy"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/hpccache -v -run "TestAccHPCCacheNFSTarget_accessPolicy" -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/01 11:23:27 [DEBUG] not using binary driver name, it's no longer needed
2021/04/01 11:23:27 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHPCCacheNFSTarget_accessPolicy
=== PAUSE TestAccHPCCacheNFSTarget_accessPolicy
=== CONT  TestAccHPCCacheNFSTarget_accessPolicy
 --- PASS: TestAccHPCCacheNFSTarget_accessPolicy (2832.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hpccache    2832.392s

@katbyte katbyte added this to the v2.54.0 milestone Apr 2, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 0dbf897 into hashicorp:master Apr 2, 2021
katbyte added a commit that referenced this pull request Apr 2, 2021
@ghost
Copy link

ghost commented May 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants