Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format #11157

Merged
merged 1 commit into from
Apr 7, 2021
Merged

azurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format #11157

merged 1 commit into from
Apr 7, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Mar 30, 2021

azurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format

$ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventGridDataConnection_mappingRule' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventGridDataConnection_mappingRule -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKustoEventGridDataConnection_mappingRule
=== PAUSE TestAccKustoEventGridDataConnection_mappingRule
=== CONT  TestAccKustoEventGridDataConnection_mappingRule
--- PASS: TestAccKustoEventGridDataConnection_mappingRule (1647.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto	1648.919s

Fixes #10977

@favoretti
Copy link
Collaborator Author

@mbfrahry Would you be so kind to take a look at this one please?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - this LGTM 👍

@katbyte katbyte added this to the v2.55.0 milestone Apr 7, 2021
@katbyte katbyte merged commit c8875e3 into hashicorp:master Apr 7, 2021
katbyte added a commit that referenced this pull request Apr 7, 2021
r0bnet pushed a commit to r0bnet/terraform-provider-azurerm that referenced this pull request Apr 8, 2021
…apping_rule_name` and `data_format` (hashicorp#11157)

zurerm_eventgrid_data_connection: add support for table_name, mapping_rule_name and data_format

$ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventGridDataConnection_mappingRule' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventGridDataConnection_mappingRule -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
2021/03/30 16:20:12 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKustoEventGridDataConnection_mappingRule
=== PAUSE TestAccKustoEventGridDataConnection_mappingRule
=== CONT  TestAccKustoEventGridDataConnection_mappingRule
--- PASS: TestAccKustoEventGridDataConnection_mappingRule (1647.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto	1648.919s
Fixes hashicorp#10977
r0bnet pushed a commit to r0bnet/terraform-provider-azurerm that referenced this pull request Apr 8, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kusto_eventgrid_data_connection is missing table_name, mapping_rule_name, data_format
2 participants