Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management: make certificate_password optional #11139

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

MattiasAng
Copy link
Contributor

Couldn't find an issue for this when looking, but my guess is that a lot (including me) uses a workaround and setting password to empty string when importing certificates that doesn't have a password.

Certificate added for testdata is just a base64 encoded x509 from the pfx that is used.

Copy link
Collaborator

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MattiasAng thank you for the PR. LGTM 👍🏻

@favoretti favoretti added this to the v2.54.0 milestone Mar 30, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! 👍

@katbyte katbyte merged commit 068c823 into hashicorp:master Mar 30, 2021
katbyte added a commit that referenced this pull request Mar 30, 2021
rm-hull added a commit to rm-hull/terraform-provider-azurerm that referenced this pull request Mar 31, 2021
…vider-azurerm

* 'master' of github.com:terraform-providers/terraform-provider-azurerm: (68 commits)
  Update changelog for hashicorp#11164
  `azurerm_cognitive_account` - Add support for `network_acls` (hashicorp#11164)
  Update CHANGELOG.md for hashicorp#11069
  New Resource: `azurerm_management_group_subscription_association` (hashicorp#11069)
  tests: limit running VMware tests in teamcity (hashicorp#11167)
  CHANGELOG.md for hashicorp#10627
  azurerm_firewall: support for private_ip_ranges (hashicorp#10627)
  Update CHANGELOG.md for hashicorp#11083
  Upgrade hpc cache API version to 2021-03-01 (hashicorp#11083)
  CHANGELOG.md for hashicorp#10724
  new resource: azurerm_media_live_event (hashicorp#10724)
  CHANGELOG.md for hashicorp#11108
  upgrade go sdk to v52.6.0 (hashicorp#11108)
  CHANGELOG.md for hashicorp#11139
  azurerm_api_management: make certificate_password optional (hashicorp#11139)
  CHANGELOG.md for hashicorp#10830
  r/azurerm_data_factory_linked_service_azure_blob_storage: Fixing managed identity implementation (hashicorp#10830)
  CHANGELOG.md for hashicorp#11131
  azurerm_storage_account - support for 'container_delete_retention_policy' (hashicorp#11131)
  CHANGELOG.md for hashicorp#11106
  ...
@ghost
Copy link

ghost commented Apr 2, 2021

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants