Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_site_recovery_fabric - Fixes error in checking for existing resource #11130

Merged

Conversation

martenbohlin
Copy link
Contributor

@martenbohlin martenbohlin commented Mar 26, 2021

Fixes #11019 and the currently failing acceptance test TestAccSiteRecoveryFabric_basic

…res already a existing resource when creating a new.
@ghost ghost added the size/XS label Mar 26, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martenbohlin, good spot - LGTM 👍

@jackofallops
Copy link
Member

Tests looking good
image

@jackofallops jackofallops added this to the v2.54.0 milestone Mar 29, 2021
@jackofallops jackofallops changed the title Fix for #11019. azurerm_site_recovery_fabric - Fixes error in checking for existing resource Mar 29, 2021
@jackofallops jackofallops merged commit 235bfb0 into hashicorp:master Mar 29, 2021
jackofallops added a commit that referenced this pull request Mar 29, 2021
MattiasAng pushed a commit to MattiasAng/terraform-provider-azurerm that referenced this pull request Mar 29, 2021
…res already a existing resource when creating a new. (hashicorp#11130)
@ghost
Copy link

ghost commented Apr 2, 2021

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_site_recovery_fabric Error: Error checking for presence of existing site recovery fabric
2 participants