New Resource azurerm_healthbot

[haiyuazhang]

Support for Azure health bot Service

The ACC Test PASS log:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/bot -run=TestAccBotHealthbot* -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/21 14:03:44 [DEBUG] not using binary driver name, it's no longer needed
2021/04/21 14:03:46 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccBotHealthbot_basic
=== PAUSE TestAccBotHealthbot_basic
=== RUN   TestAccBotHealthbot_requiresImport
=== PAUSE TestAccBotHealthbot_requiresImport
=== RUN   TestAccBotHealthbot_complete
=== PAUSE TestAccBotHealthbot_complete
=== RUN   TestAccBotHealthbot_update
=== PAUSE TestAccBotHealthbot_update
=== CONT  TestAccBotHealthbot_basic
=== CONT  TestAccBotHealthbot_update
=== CONT  TestAccBotHealthbot_complete
=== CONT  TestAccBotHealthbot_requiresImport
--- PASS: TestAccBotHealthbot_complete (202.30s)
--- PASS: TestAccBotHealthbot_basic (205.21s)
--- PASS: TestAccBotHealthbot_requiresImport (216.32s)
--- PASS: TestAccBotHealthbot_update (331.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/bot 332.966s

[katbyte]

Thanks @haiyuazhang 0 overall this looks good btu i've left some questions inline to address

[katbyte]

thanks @haiyuazhang - i think azurerm_bot_healthbot is a bit redundant as it has bot in it twice, if we change this to azurerm_healthbot i think this will be good to merge!

[haiyuazhang]

@katbyte
I've rename the resource to azurerm_healthbot. Besides, I've rebased the code from master branch to fix the deps check error caused by the sdk version upgrade in master branch. Thanks for your comments and review.

[katbyte]

Thanks @haiyuazhang - aside from one comment about a property name this looks good - once that is changed this should be good to merge!

[katbyte]

Thanks @haiyuazhang - aside from one comment about a property name this looks good - once that is changed this should be good to merge!

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.