azurerm_key_vault: waiting for 10 successful dns locators before returning as created

[tombuildsstuff]

Switching over to ensure the DNS is resolved 10 times in a row before marking the KeyVault resource as successfully provisioned.

This should fix #655 but it's hard to tell since it fails sporadically:

* azurerm_key_vault_secret.test-secret: azurerm_key_vault_secret.test-secret: Error making Read request on Azure KeyVault Secret acctestsecret-5272604717641362572: keyvault.BaseClient#GetSecret: Failure sending request: StatusCode=0 -- Original Error: Get https://vault5272604717641362572.vault.azure.net/secrets/acctestsecret-5272604717641362572/?api-version=2016-10-01: dial tcp: lookup vault5272604717641362572.vault.azure.net on 192.168.22.2:53: no such host

[catsby]

👍 assuming relevant tests pass

[pixelicous]

@tombuildsstuff was this merged to 1.3.3? Doesn't seem like it..

[tombuildsstuff]

@pixelicous not yet, this is still WIP as this fix needs some additional tweaking

[pixelicous]

@tombuildsstuff thx! We opened a ficket with MS about this, as its related.. I remember writing you an official response from MS about how to handle that timeout but i cant seem to find which post it was on.. Ill post it again here if i dont find it soon, they are implementing a few changes but ita going to take a while probably

[tombuildsstuff]

Also now fixes #1005

[mbfrahry]

LGTM

[tombuildsstuff]

Key Vault tests pass:

[tombuildsstuff]

hey @pixelicous

Just to let you know that v1.4.0 of the Azure Provider has been released which includes the fix for this :)

Thanks!

[pixelicous]

@tombuildsstuff hey! i saw :) amazing, and just as i decided to implement the null_resource with a sleep 😄

kudos for the quick timeframe between 1.3.3 and 1.4 🔥 ❕

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!